bhyve: populate device version from backend

[aokblast]

Summary

The pci_xhci driver requires the USB device version to be known before allocating a hub port. To support this, we split the original xHCI initialization into two phases:

1. Probe: Parse the nvlist and determine the device version.
2. Init: Complete initialization and set up the softc details.

This change ensures proper hub port allocation based on accurate device
version.

Sponsored by: The FreeBSD Foundation

[lwhsu]

I think this is fine, but I'd like one more reviewer to confirm.

[markj]

usr.sbin/bhyve/pci_xhci.c

2856

Now we need to clean up the devsc in these error paths.

[aokblast]

Free when bad init

[markj]

usr.sbin/bhyve/pci_xhci.c

2902

I think we probably also need to free dev->dev_sc here? Taking care to avoid a double free after the assignment XHCI_DEVINST_PTR(sc, dev->hci.hci_port) = dev above.

[aokblast]

Fix memory leak

[aokblast]

usr.sbin/bhyve/pci_xhci.c

2902

Emm, I think we have a memory leak problem before this patch. When control flow goto bad in

if (usb2_port == sc->usb2_port_start +
			    XHCI_MAX_DEVS / 2)

or

if (usb3_port == sc->usb3_port_start +
			    XHCI_MAX_DEVS / 2)

The last dev never freed. I think it should be fixed properly now.

[markj]

Approved with the inline comments resolved.

usr.sbin/bhyve/pci_xhci.c

2841

Still need to free dev here.

2900

2902

Yes, I agree.

[aokblast]

Minor update

[aokblast]

usr.sbin/bhyve/pci_xhci.c

2788–2789

I think this line is unnecessary now since we decide to close manually for any error before

XHCI_DEVINST_PTR(sc, dev->hci.hci_port) = dev;

. I will delete it before merging back.