Page MenuHomeFreeBSD

libusb: make hotplug callback handle an int
Needs ReviewPublic

Authored by bapt on Fri, Mar 6, 8:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 22, 12:26 AM
Unknown Object (File)
Fri, Mar 20, 7:12 AM
Unknown Object (File)
Thu, Mar 19, 6:32 AM
Unknown Object (File)
Fri, Mar 13, 9:23 PM
Unknown Object (File)
Fri, Mar 13, 11:23 AM
Unknown Object (File)
Wed, Mar 11, 10:10 AM
Unknown Object (File)
Wed, Mar 11, 8:44 AM
Unknown Object (File)
Wed, Mar 11, 5:17 AM
Subscribers

Details

Reviewers
emaste
Group Reviewers
USB
Summary

Change libusb_hotplug_callback_handle from a pointer to an int,
matching the sourceforge's libusb API.
Handle backward compatibility.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71221
Build 68104: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Fri, Mar 6, 8:09 AM

this one in particular I would love to get a review, this is the first time I plan with symbol version compatibility

kib added inline comments.
lib/libusb/libusb10_hotplug.c
531

Why not list the default symbols in Symbol.map?

538

This cannot work, you cannot export two different objects under same name+version. The point of versioning is to provide different versions.

this one in particular I would love to get a review, this is the first time I plan with symbol version compatibility

Hi bapt@, please tell after you finish you work so that I can merge this.
Or would you like to help me merge it after your work?

Update: sorry that I didn't notice that it is a different patch.