Details

Reviewers

des
kevans
cy

Commits

rGfb1ccc04adfe: krb5: don't install libdb manual pages

Summary

This version of libdb is private to Kerberos and not intended for
external use, so avoid installing manual pages that may conflict
with another version of libdb.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65688
Build 62571: arc lint + arc unit

Event Timeline

ivy created this revision.Jul 19 2025, 2:50 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 19 2025, 2:50 AM

ivy requested review of this revision.Jul 19 2025, 2:50 AM

Harbormaster completed remote builds in B65574: Diff 158769.Jul 19 2025, 2:50 AM

ivy added a child revision: D51419: krb5: don't install /usr/include/import_err.h.Jul 19 2025, 2:51 AM

des added inline comments.Jul 24 2025, 1:39 PM

krb5/plugins/kdb/db2/Makefile
47–48	This line is redundant.

des added inline comments.Jul 24 2025, 1:41 PM

krb5/plugins/kdb/db2/Makefile
12	`<bsd.lib.mk>` already does this.

add the manpages to ObsoleteFiles

since WITH_MITKRB5 became the default a few days ago, it's likely people have
these installed now. note that they aren't OptionalObsoleteFiles because they
should never be installed regardless of which (if any) Kerberos you choose.

Harbormaster completed remote builds in B65687: Diff 159052.Jul 25 2025, 7:58 AM

remove redundant .SUFFIXES

Harbormaster completed remote builds in B65688: Diff 159053.Jul 25 2025, 8:02 AM

ivy marked an inline comment as done.Jul 25 2025, 8:03 AM

ivy added inline comments.

krb5/plugins/kdb/db2/Makefile
12	but is this still required for the `.include` on line 30 to work? or is `KRB5_SRCTOP` set in the environment? (i can run a test build but since nearly all the krb5 makefiles have this include, it might make sense to do that in a separate change.)

des accepted this revision.Jul 25 2025, 12:11 PM

des added inline comments.

krb5/plugins/kdb/db2/Makefile
12	move that other `.include` to the bottom, it does not need to precede the `CFLAGS` line since `KRB5_DIR` is not expanded when `CFLAGS` is set but when it is used.