stand allow for local.defs.mk
ClosedPublic
Actions

Authored by sjg on May 22 2025, 9:40 PM.

Details

Reviewers

imp
kevans
stevek
manu

Commits

rG2982c7085239: stand allow for local.defs.mk

Summary

This allows us to change the VERSION_FILE used for loaders
as well as set NEWVERS_DATE and BUILD_UTC to reflect the publish
date of loaders for secure-boot.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sjg created this revision.May 22 2025, 9:40 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 22 2025, 9:40 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

sjg requested review of this revision.May 22 2025, 9:40 PM

Harbormaster completed remote builds in B64368: Diff 155896.May 22 2025, 9:41 PM

So except maybe for the newvers.sh issue I flagged, this is good.

stand/common/newvers.sh
53	Any reason you can't use SOURCE_DATE_EPOCH here? It seems to be the same feature with a different name...

This revision is now accepted and ready to land.May 22 2025, 9:49 PM

sjg marked an inline comment as done.May 22 2025, 10:46 PM

sjg added inline comments.

stand/common/newvers.sh
53	SOURCE_DATE_EPOCH is a timestamp - we want to control the format as well so it is easier for customers and support folk to recognize that the date reported by the loader matches a publish date - fwiw we use "%Y%m%d %H%M%S",