ifnet: Make if_detach_internal() and if_vmove() void
ClosedPublic
Actions

Authored by zlei on Feb 3 2025, 6:42 PM.

Details

Reviewers

kp
kevans
glebius

Group Reviewers

network

Commits

rGe0b2b8fa16a1: ifnet: Make if_detach_internal() and if_vmove() void
rG700880a13566: ifnet: Make if_detach_internal() and if_vmove() void
rGbb0348a17974: ifnet: Make if_detach_internal() and if_vmove() void

Summary

if_detach_internal() never fail since change [1]. As a consequence,
also does its caller if_vmove(). While here, remove a stall comment.

No functional change intended.

This reverts commit c7bab2a7ca9a6dae79f970c6730a19b65a1ed86e.

[1] a779388f8bb3 if: Protect V_ifnet in vnet_if_return()

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Feb 3 2025, 6:42 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptFeb 3 2025, 6:42 PM

zlei requested review of this revision.Feb 3 2025, 6:42 PM

glebius accepted this revision as: glebius.Feb 3 2025, 6:46 PM

This revision is now accepted and ready to land.Feb 3 2025, 6:46 PM

Closed by commit rGbb0348a17974: ifnet: Make if_detach_internal() and if_vmove() void (authored by zlei). · Explain WhyFeb 4 2025, 3:06 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGbb0348a17974: ifnet: Make if_detach_internal() and if_vmove() void.

zlei added a commit: rG700880a13566: ifnet: Make if_detach_internal() and if_vmove() void.Feb 6 2025, 7:12 PM

zlei added a commit: rGe0b2b8fa16a1: ifnet: Make if_detach_internal() and if_vmove() void.Feb 6 2025, 7:18 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

43 lines

Diff 150468

View Options

ifnet: Make if_detach_internal() and if_vmove() voidClosedPublicActions