Page MenuHomeFreeBSD
Differential D48614

net80211: add static initialisers for the ieee80211_node_txrate options
ClosedPublic
Actions

Authored by adrian on Jan 23 2025, 2:45 AM.
Tags
Referenced Files
F134125645: D48614.id150012.diff
Thu, Oct 30, 11:54 PM
Unknown Object (File)
Sun, Oct 26, 6:58 AM
Unknown Object (File)
Fri, Oct 24, 10:28 AM
Unknown Object (File)
Fri, Oct 24, 1:29 AM
Unknown Object (File)
Thu, Oct 23, 7:03 AM
Unknown Object (File)
Tue, Oct 21, 9:46 PM
Unknown Object (File)
Mon, Oct 20, 5:57 PM
Unknown Object (File)
Sat, Oct 18, 6:29 PM
View All Files
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
thj
bz
Group Reviewers
wireless
Commits
rG62823019db16: net80211: add static initialisers for the ieee80211_node_txrate options
Summary

Add static initialisers for legacy, ht and vht rates.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61994
Build 58878: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 23 2025, 2:45 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 23 2025, 2:45 AM
adrian requested review of this revision.Jan 23 2025, 2:45 AM
Harbormaster completed remote builds in B61907: Diff 149745.Jan 23 2025, 2:45 AM
adrian added a parent revision: D48613: net80211: update ieee80211_node_get_txrate_mbit() to support VHT.Jan 23 2025, 2:45 AM
adrian added a child revision: D48615: net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate.
adrian added a reviewer: wireless.Jan 23 2025, 3:07 AM
adrian added a project: wireless.
adrian updated this revision to Diff 149856.Jan 24 2025, 1:53 AM

rebase

Harbormaster completed remote builds in B61967: Diff 149856.Jan 24 2025, 1:53 AM
adrian updated this revision to Diff 149908.Jan 24 2025, 3:32 PM

rebase

Harbormaster completed remote builds in B61994: Diff 149908.Jan 24 2025, 3:32 PM
adrian updated this revision to Diff 150012.Jan 27 2025, 12:16 AM

rebase, address changes

Harbormaster completed remote builds in B62060: Diff 150012.Jan 27 2025, 12:16 AM
thj accepted this revision.Jan 28 2025, 10:01 AM
This revision is now accepted and ready to land.Jan 28 2025, 10:01 AM
bz added a subscriber: bz.Jan 29 2025, 12:44 AM
bz added inline comments.
sys/net80211/ieee80211_node.h
162

Still feels wrong. Would you really be up for fixing all these instances to use mcs once this stack is cleared?

adrian updated this revision to Diff 150173.Jan 30 2025, 5:16 AM

update, add TXRATE_HT

This revision now requires review to proceed.Jan 30 2025, 5:16 AM
Harbormaster completed remote builds in B62138: Diff 150173.Jan 30 2025, 5:16 AM
adrian marked an inline comment as done.Feb 11 2025, 12:45 AM
adrian added inline comments.
sys/net80211/ieee80211_node.h
162

oh I fixed it but I did not fix THIS, one moment!

adrian updated this revision to Diff 150813.Feb 11 2025, 12:48 AM
adrian marked an inline comment as done.

update static initialiser for HT, now that HT is its own type now

Harbormaster completed remote builds in B62351: Diff 150813.Feb 11 2025, 12:48 AM
adrian updated this revision to Diff 150814.Feb 11 2025, 12:55 AM

oops, another fix

Harbormaster completed remote builds in B62352: Diff 150814.Feb 11 2025, 12:56 AM
adrian updated this revision to Diff 150815.Feb 11 2025, 12:58 AM

rename the args to something that won't clash

the VHT macro isn't yet used, and it would've errored out if I did!

Harbormaster completed remote builds in B62353: Diff 150815.Feb 11 2025, 12:58 AM
bz accepted this revision.Feb 22 2025, 11:13 AM
This revision is now accepted and ready to land.Feb 22 2025, 11:13 AM
Closed by commit rG62823019db16: net80211: add static initialisers for the ieee80211_node_txrate options (authored by adrian). · Explain WhyFeb 26 2025, 7:32 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG62823019db16: net80211: add static initialisers for the ieee80211_node_txrate options.

Revision Contents
Changeset List

PathSize
sys/
net80211/
18 lines

Diff 149908

View Options

sys/net80211/ieee80211_node.h

Loading...