Differential D48410

stand/kshim: Implement bus_detach_children
ClosedPublic
Actions

Authored by jhb on Fri, Jan 10, 3:22 AM.

Tags

None

Referenced Files

	F107345501: D48410.diff
	Sun, Jan 12, 7:38 PM

	F107294940: D48410.id149115.diff
	Sun, Jan 12, 3:22 AM

	Unknown Object (File)
	Sat, Jan 11, 9:49 AM

	Unknown Object (File)
	Sat, Jan 11, 9:45 AM

	Unknown Object (File)
	Sat, Jan 11, 6:30 AM

	Unknown Object (File)
	Sat, Jan 11, 4:26 AM

Subscribers

Details

Reviewers

imp
markj
emaste
manu

Commits

rG8e4535ee5870: stand/kshim: Implement bus_detach_children

Summary

While here, update bus_generic_detach to delete devices as in the
kernel.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Fri, Jan 10, 3:22 AM

Herald added a reviewer: manu. · View Herald TranscriptFri, Jan 10, 3:22 AM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Fri, Jan 10, 3:22 AM

jhb added a parent revision: D48409: stand/usb: Update for devclass being removed from DRIVER_MODULE.

Harbormaster completed remote builds in B61634: Diff 149031.Fri, Jan 10, 3:22 AM

jhb added a child revision: D48411: stand/usb: Quiet warnings so this builds again.Fri, Jan 10, 3:22 AM

imp accepted this revision.Fri, Jan 10, 4:41 AM

This revision is now accepted and ready to land.Fri, Jan 10, 4:41 AM

markj accepted this revision.Fri, Jan 10, 2:01 PM

markj added inline comments.

stand/kshim/bsd_kernel.c
689	device_delete_children() will call device_detach() on each child again, but I think that's harmless.

jhb added inline comments.Sat, Jan 11, 4:00 AM

stand/kshim/bsd_kernel.c
689	Yes, and this is also true in the kernel implementation. The difference is that here we don't delete any devices if a child device vetos the detach operation.

Closed by commit rG8e4535ee5870: stand/kshim: Implement bus_detach_children (authored by jhb). · Explain WhySat, Jan 11, 4:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8e4535ee5870: stand/kshim: Implement bus_detach_children.

Revision Contents
Changeset List

Path

Size

stand/

kshim/

1 line

13 lines

Diff 149115

stand/kshim/bsd_kernel.h

Loading...

stand/kshim/bsd_kernel.c

Loading...