Page MenuHomeFreeBSD
Differential D48367

DEVICE_IDENTIFY.9: Modernize description and use cases
ClosedPublic
Actions

Authored by jhb on Tue, Jan 7, 5:05 PM.
Tags
None
Referenced Files
F108533376: D48367.diff
Sun, Jan 26, 12:17 AM
Unknown Object (File)
Fri, Jan 24, 4:27 PM
Unknown Object (File)
Wed, Jan 15, 4:41 PM
Unknown Object (File)
Wed, Jan 15, 3:53 AM
Unknown Object (File)
Sun, Jan 12, 10:01 PM
Unknown Object (File)
Sat, Jan 11, 9:04 AM
Unknown Object (File)
Sat, Jan 11, 2:13 AM
Unknown Object (File)
Thu, Jan 9, 11:30 PM
View All 11 Files
Subscribers
ziaee

Details

Reviewers
imp
ziaee
Group Reviewers
manpages
Commits
rGccabc7c2e556: DEVICE_IDENTIFY.9: Modernize description and use cases
Summary

Mention adding devices based on firmware tables and software-only
pseudo-devices as use cases for identify methods as those are more
common than reading random I/O ports to identify a legacy ISA device.

Describe how device_find_chid can be used to avoid duplicates. While
here, explicitly note that devices added in identify methods typically
use a fixed device name.

Trim the cross-references a bit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Tue, Jan 7, 5:05 PM
jhb created this revision.
jhb added a parent revision: D48366: BUS_HINTED_CHILD.9: New manpage to document this bus method.
jhb added a child revision: D48368: bus_attach_children.9: New manpage for functions operating on children.
Harbormaster completed remote builds in B61554: Diff 148888.Tue, Jan 7, 5:05 PM
ziaee added a reviewer: manpages.Wed, Jan 8, 2:00 AM
ziaee added a subscriber: ziaee.
ziaee added inline comments.
share/man/man9/DEVICE_IDENTIFY.9
34

Wow this seems way better!

87

Sir, I see device_get_children but not device_get_child on current from yesterday.

imp accepted this revision.Wed, Jan 8, 2:12 AM

Couple of nits,but it's so much better

share/man/man9/DEVICE_IDENTIFY.9
43

in various ways?

50–53

Extra space?

This revision is now accepted and ready to land.Wed, Jan 8, 2:12 AM
jhb added inline comments.Wed, Jan 8, 6:27 PM
share/man/man9/DEVICE_IDENTIFY.9
87

It's added in a commit later in this stack

ziaee accepted this revision.Thu, Jan 9, 2:18 AM
jhb marked 3 inline comments as done.Thu, Jan 9, 8:18 PM
jhb added inline comments.
share/man/man9/DEVICE_IDENTIFY.9
87

Oh, this is supposed to be device_find_child

Closed by commit rGccabc7c2e556: DEVICE_IDENTIFY.9: Modernize description and use cases (authored by jhb). · Explain WhyThu, Jan 9, 8:21 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGccabc7c2e556: DEVICE_IDENTIFY.9: Modernize description and use cases.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
52 lines

Diff 149013

View Options

share/man/man9/DEVICE_IDENTIFY.9

Loading...