Page MenuHomeFreeBSD
Differential D48411

stand/usb: Quiet warnings so this builds again
ClosedPublic
Actions

Authored by jhb on Jan 10 2025, 3:22 AM.
Tags
None
Referenced Files
F171137545: D48411.diff
Tue, Sep 8, 10:50 PM
Unknown Object (File)
Tue, Sep 8, 2:55 PM
Unknown Object (File)
Tue, Sep 8, 7:26 AM
Unknown Object (File)
Sun, Sep 6, 12:54 AM
Unknown Object (File)
Sat, Sep 5, 10:39 PM
Unknown Object (File)
Sat, Sep 5, 8:00 PM
Unknown Object (File)
Sat, Sep 5, 6:33 PM
Unknown Object (File)
Sat, Sep 5, 6:03 PM
View All Files
Subscribers
dab

Details

Reviewers
imp
markj
emaste
manu
Commits
rGaa2b4a172621: stand/usb: Quiet warnings so this builds again
rGf6f5aa8a2df5: stand/usb: Quiet warnings so this builds again

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 10 2025, 3:22 AM
Herald added a reviewer: manu. · View Herald TranscriptJan 10 2025, 3:22 AM
Herald added a subscriber: dab. · View Herald Transcript
jhb requested review of this revision.Jan 10 2025, 3:22 AM
jhb added a parent revision: D48410: stand/kshim: Implement bus_detach_children.
Harbormaster completed remote builds in B61635: Diff 149032.Jan 10 2025, 3:22 AM
jhb added a child revision: D48412: stand/kshim: Replace devclass_equal with calls to strcmp.Jan 10 2025, 3:22 AM
jhb added a comment.Jan 10 2025, 3:25 AM

I do not know how to actually test this but it builds again. I had to do a hack to build tools/sysinit and then symlink that into my path to get stand/usb to actually build. I can run the test program but it doesn't do anything (and I'm not sure how to get it to do anything).

stand/usb/Makefile
38

This is due to warnings about an unused struct sysctl_oid *parent in the cdce(4) driver since all the SYSCTL stuff is stubbed out.

stand/usb/test/Makefile
38

For some reason, just using -Wno-missing-prototypes and -Wno-unused-parameter did not work.

markj accepted this revision.Jan 10 2025, 2:02 PM

I have no real idea how to test this code either.

This revision is now accepted and ready to land.Jan 10 2025, 2:02 PM
emaste accepted this revision.Jan 10 2025, 8:04 PM

No objection here

Closed by commit rGf6f5aa8a2df5: stand/usb: Quiet warnings so this builds again (authored by jhb). · Explain WhyJan 11 2025, 4:04 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGf6f5aa8a2df5: stand/usb: Quiet warnings so this builds again.
jhb added a commit: rGaa2b4a172621: stand/usb: Quiet warnings so this builds again.Feb 27 2025, 4:56 PM

Revision Contents
Changeset List

PathSize
stand/
usb/
2 lines
test/
1 line

Diff 149116

View Options

stand/usb/Makefile

Loading...
View Options

stand/usb/test/Makefile

Loading...