Differential D48409

stand/usb: Update for devclass being removed from DRIVER_MODULE
ClosedPublic
Actions

Authored by jhb on Jan 10 2025, 3:22 AM.

Tags

None

Referenced Files

	F163349001: D48409.id.diff
	Wed, Jul 22, 9:37 AM

	F163348985: D48409.id.diff
	Wed, Jul 22, 9:37 AM

	Unknown Object (File)
	Mon, Jul 20, 5:22 AM

	Unknown Object (File)
	Fri, Jul 10, 1:42 AM

	Unknown Object (File)
	Fri, Jul 3, 6:23 AM

	Unknown Object (File)
	Wed, Jul 1, 11:56 PM

	Unknown Object (File)
	Wed, Jul 1, 2:15 AM

	Unknown Object (File)
	Tue, Jun 30, 4:42 AM

Subscribers

Details

Reviewers

imp
markj
emaste
manu

Commits

rGbc8f3704f1d8: stand/kshim: Update for devclass being removed from DRIVER_MODULE
rGee15875c0159: stand/kshim: Update for devclass being removed from DRIVER_MODULE

Summary

The kshim code abused the devclass argument to DRIVER_MODULE in some
odd ways. Instead, refactor the devclass handling to more closely
mirror what new-bus does in the kernel by having a linked list of
devclasses looked up by name and associate devices with a devclass.

Devices are now only associated with a module while probing and
attaching.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 10 2025, 3:22 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 10 2025, 3:22 AM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Jan 10 2025, 3:22 AM

Harbormaster completed remote builds in B61633: Diff 149030.Jan 10 2025, 3:22 AM

jhb added a child revision: D48410: stand/kshim: Implement bus_detach_children.Jan 10 2025, 3:22 AM

Love the concept. Spot checked the impl. Structure is good, but didn't dive deeply in.

This revision is now accepted and ready to land.Jan 10 2025, 4:40 AM

jhb added a parent revision: D48404: kshim: Replace bus_generic_attach with bus_attach_children.Jan 10 2025, 12:03 PM

markj accepted this revision.Jan 10 2025, 1:54 PM

Closed by commit rGee15875c0159: stand/kshim: Update for devclass being removed from DRIVER_MODULE (authored by jhb). · Explain WhyJan 11 2025, 4:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGee15875c0159: stand/kshim: Update for devclass being removed from DRIVER_MODULE.

jhb added a commit: rGbc8f3704f1d8: stand/kshim: Update for devclass being removed from DRIVER_MODULE.Feb 27 2025, 4:56 PM

Revision Contents
Changeset List

Path

Size

stand/

kshim/

11 lines

140 lines

usb/

storage/

4 lines

Diff 149114

stand/kshim/bsd_kernel.h

Loading...

stand/kshim/bsd_kernel.c

Loading...

stand/usb/storage/umass_common.c

Loading...