Paths

Table of Contentst

Differential D48412

stand/kshim: Replace devclass_equal with calls to strcmp
ClosedPublic
Actions

Authored by jhb on Jan 10 2025, 3:22 AM.

Tags

None

Referenced Files

	F132963996: D48412.id149033.diff
	Tue, Oct 21, 2:54 PM

	Unknown Object (File)
	Tue, Oct 21, 3:03 AM

	Unknown Object (File)
	Sun, Oct 19, 11:12 AM

	Unknown Object (File)
	Sat, Oct 18, 11:42 AM

	Unknown Object (File)
	Wed, Oct 8, 5:52 PM

	Unknown Object (File)
	Wed, Sep 24, 11:28 PM

	Unknown Object (File)
	Sep 21 2025, 12:36 AM

	Unknown Object (File)
	Sep 11 2025, 7:37 AM

View All 49 Files

Subscribers

Details

Reviewers

imp
markj
emaste
manu

Commits

rGb67839d769dd: stand/kshim: Replace devclass_equal with calls to strcmp
rG40d7ba087737: stand/kshim: Replace devclass_equal with calls to strcmp

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 10 2025, 3:22 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 10 2025, 3:22 AM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Jan 10 2025, 3:22 AM

Harbormaster completed remote builds in B61636: Diff 149033.Jan 10 2025, 3:22 AM

jhb added a parent revision: D48411: stand/usb: Quiet warnings so this builds again.Jan 10 2025, 3:22 AM

We lose the tiny a == b optimization but I can't imagine that matters.

This revision is now accepted and ready to land.Jan 10 2025, 3:45 AM

imp accepted this revision.Jan 10 2025, 4:08 AM

imp added inline comments.

stand/kshim/bsd_kernel.c
888	So hps was a smart fellow. Why did he do it this odd, tortued way?

jhb added inline comments.Jan 10 2025, 12:02 PM

stand/kshim/bsd_kernel.c
888	Maybe the a == b check? I'm not sure. It is also odd how many places it was used in places that had nothing to do with devclasses.

markj accepted this revision.Jan 10 2025, 1:56 PM

Closed by commit rG40d7ba087737: stand/kshim: Replace devclass_equal with calls to strcmp (authored by jhb). · Explain WhyJan 11 2025, 4:04 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG40d7ba087737: stand/kshim: Replace devclass_equal with calls to strcmp.

jhb added a commit: rGb67839d769dd: stand/kshim: Replace devclass_equal with calls to strcmp.Feb 27 2025, 4:56 PM

Revision Contents
Changeset List

Path

Size

stand/

kshim/

27 lines

Diff 149117

stand/kshim/bsd_kernel.c

Loading...