Page MenuHomeFreeBSD
Differential D48412

stand/kshim: Replace devclass_equal with calls to strcmp
ClosedPublic
Actions

Authored by jhb on Jan 10 2025, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 4:10 AM
Unknown Object (File)
Sun, Jan 26, 12:19 AM
Unknown Object (File)
Sat, Jan 25, 5:38 PM
Unknown Object (File)
Thu, Jan 23, 6:58 PM
Unknown Object (File)
Thu, Jan 23, 6:54 PM
Unknown Object (File)
Thu, Jan 23, 3:26 PM
Unknown Object (File)
Jan 14 2025, 6:53 PM
Unknown Object (File)
Jan 12 2025, 6:02 PM
View All 15 Files
Subscribers
dab

Details

Reviewers
imp
markj
emaste
manu
Commits
rG40d7ba087737: stand/kshim: Replace devclass_equal with calls to strcmp

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 10 2025, 3:22 AM
Herald added a reviewer: manu. · View Herald TranscriptJan 10 2025, 3:22 AM
Herald added a subscriber: dab. · View Herald Transcript
jhb requested review of this revision.Jan 10 2025, 3:22 AM
Harbormaster completed remote builds in B61636: Diff 149033.Jan 10 2025, 3:22 AM
jhb added a parent revision: D48411: stand/usb: Quiet warnings so this builds again.Jan 10 2025, 3:22 AM
emaste accepted this revision.Jan 10 2025, 3:45 AM

We lose the tiny a == b optimization but I can't imagine that matters.

This revision is now accepted and ready to land.Jan 10 2025, 3:45 AM
imp accepted this revision.Jan 10 2025, 4:08 AM
imp added inline comments.
stand/kshim/bsd_kernel.c
888

So hps was a smart fellow. Why did he do it this odd, tortued way?

jhb added inline comments.Jan 10 2025, 12:02 PM
stand/kshim/bsd_kernel.c
888

Maybe the a == b check? I'm not sure. It is also odd how many places it was used in places that had nothing to do with devclasses.

markj accepted this revision.Jan 10 2025, 1:56 PM
Closed by commit rG40d7ba087737: stand/kshim: Replace devclass_equal with calls to strcmp (authored by jhb). · Explain WhyJan 11 2025, 4:04 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG40d7ba087737: stand/kshim: Replace devclass_equal with calls to strcmp.

Revision Contents
Changeset List

PathSize
stand/
kshim/
27 lines

Diff 149117

View Options

stand/kshim/bsd_kernel.c

Loading...