Page MenuHomeFreeBSD
Differential D48412

stand/kshim: Replace devclass_equal with calls to strcmp
AcceptedPublic
Actions

Authored by jhb on Fri, Jan 10, 3:22 AM.

Details

Reviewers
imp
markj
emaste
manu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61636
Build 58520: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Jan 10, 3:22 AM
Herald added a reviewer: manu. · View Herald TranscriptFri, Jan 10, 3:22 AM
Herald added a subscriber: dab. · View Herald Transcript
jhb requested review of this revision.Fri, Jan 10, 3:22 AM
Harbormaster completed remote builds in B61636: Diff 149033.Fri, Jan 10, 3:22 AM
jhb added a parent revision: D48411: stand/usb: Quiet warnings so this builds again.Fri, Jan 10, 3:22 AM
emaste accepted this revision.Fri, Jan 10, 3:45 AM

We lose the tiny a == b optimization but I can't imagine that matters.

This revision is now accepted and ready to land.Fri, Jan 10, 3:45 AM
imp accepted this revision.Fri, Jan 10, 4:08 AM
imp added inline comments.
stand/kshim/bsd_kernel.c
888

So hps was a smart fellow. Why did he do it this odd, tortued way?

jhb added inline comments.Fri, Jan 10, 12:02 PM
stand/kshim/bsd_kernel.c
888

Maybe the a == b check? I'm not sure. It is also odd how many places it was used in places that had nothing to do with devclasses.

markj accepted this revision.Fri, Jan 10, 1:56 PM

Revision Contents
Changeset List

PathSize
stand/
kshim/
27 lines

Diff 149033

View Options

stand/kshim/bsd_kernel.c

Loading...