Page MenuHomeFreeBSD

stand/kshim: Implement bus_detach_children
ClosedPublic

Authored by jhb on Jan 10 2025, 3:22 AM.
Tags
None
Referenced Files
F110000976: D48410.diff
Wed, Feb 12, 7:28 AM
Unknown Object (File)
Thu, Feb 6, 9:19 PM
Unknown Object (File)
Tue, Feb 4, 5:31 AM
Unknown Object (File)
Sun, Jan 26, 8:45 PM
Unknown Object (File)
Sun, Jan 26, 7:22 PM
Unknown Object (File)
Sun, Jan 26, 3:18 PM
Unknown Object (File)
Sun, Jan 26, 12:19 AM
Unknown Object (File)
Thu, Jan 23, 10:31 PM
Subscribers

Details

Summary

While here, update bus_generic_detach to delete devices as in the
kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 10 2025, 4:41 AM
markj added inline comments.
stand/kshim/bsd_kernel.c
689

device_delete_children() will call device_detach() on each child again, but I think that's harmless.

stand/kshim/bsd_kernel.c
689

Yes, and this is also true in the kernel implementation. The difference is that here we don't delete any devices if a child device vetos the detach operation.

This revision was automatically updated to reflect the committed changes.