Differential D44448

nvme: Add NVMe over Fabrics fields to nvme_controller_data
ClosedPublic
Actions

Authored by jhb on Mar 20 2024, 11:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 14, 5:57 PM

	Unknown Object (File)
	May 17 2024, 8:45 PM

	Unknown Object (File)
	May 9 2024, 3:07 AM

	Unknown Object (File)
	May 8 2024, 3:04 AM

	Unknown Object (File)
	Apr 7 2024, 10:07 PM

	Unknown Object (File)
	Apr 5 2024, 7:51 PM

	Unknown Object (File)
	Mar 24 2024, 11:36 PM

	Unknown Object (File)
	Mar 23 2024, 2:21 AM

View All 9 Files

Subscribers

Details

Reviewers

imp
chuck

Commits

rG21d3a84db481: nvme: Add NVMe over Fabrics fields to nvme_controller_data

Summary

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 20 2024, 11:23 PM

Herald added a subscriber: dab. · View Herald TranscriptMar 20 2024, 11:23 PM

jhb requested review of this revision.Mar 20 2024, 11:23 PM

Harbormaster completed remote builds in B56719: Diff 136007.Mar 20 2024, 11:23 PM

jhb added a parent revision: D44447: nvme: Add constants for the Controller Attributes field in cdata.Mar 20 2024, 11:23 PM

jhb added a child revision: D44449: nvmecontrol: Display additional Fabrics-related fields for cdata.

imp accepted this revision.Mar 21 2024, 9:20 AM

imp added inline comments.

sys/dev/nvme/nvme.h
2079	I'm starting to think we should have some _Generic based interface for this sort of thing...

This revision is now accepted and ready to land.Mar 21 2024, 9:20 AM

jhb added inline comments.Mar 21 2024, 5:44 PM

sys/dev/nvme/nvme.h
2079	If we were starting from scratch perhaps, but at this point there aren't that many more fields to deal with so adding them by hand isn't that big of a deal.

imp added inline comments.Mar 22 2024, 9:17 PM

sys/dev/nvme/nvme.h
2079	Yea. It was a note to our future selves

Closed by commit rG21d3a84db481: nvme: Add NVMe over Fabrics fields to nvme_controller_data (authored by jhb). · Explain WhyMar 23 2024, 12:27 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG21d3a84db481: nvme: Add NVMe over Fabrics fields to nvme_controller_data.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

12 lines

Diff 136119

sys/dev/nvme/nvme.h

Loading...