This is not used in nvme(4) but is used in NVMe over Fabrics
transports which use SGLs to describe buffers instead of PRPs.
While here, adjust the shift value for the FUSE field to be relative
to the 'fuse' member of 'struct nvme_command'.
Details
Details
- Reviewers
imp chuck - Commits
- rGb8cb8dd3625d: nvme: Add constants for the PSDT field in cdw0
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/dev/nvme/nvme.h | ||
|---|---|---|
| 214 | Why? | |
| sys/dev/nvme/nvme.h | ||
|---|---|---|
| 214 | Hmm, I tried to say that in the last sentence: While here, adjust the shift value for the FUSE field to be relative to the 'fuse' member of 'struct nvme_command'. All of the constants we have are relative to the field in the relevant data structure. In struct nvme_command we have: struct nvme_command {
/* dword 0 */
uint8_t opc; /* opcode */
uint8_t fuse; /* fused operation */
uint16_t cid; /* command identifier */The earlier define seemed to assume that we had a single uint16_t cmd_fuse field that you would use these constants with in NVMEV to extract the fuse value. I also do end checking for fused commands in the CAM ctl(4) controller so need this value correct. | |
| sys/dev/nvme/nvme.h | ||
|---|---|---|
| 214 | I think that's good | |