Page MenuHomeFreeBSD

kernel: Move the debug stuff into a common script
ClosedPublic

Authored by imp on Feb 24 2024, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 5, 4:40 AM
Unknown Object (File)
Sat, Jul 4, 9:49 AM
Unknown Object (File)
Wed, Jul 1, 6:58 AM
Unknown Object (File)
Tue, Jun 30, 2:48 AM
Unknown Object (File)
Thu, Jun 25, 11:12 AM
Unknown Object (File)
Wed, Jun 24, 6:36 AM
Unknown Object (File)
Fri, Jun 19, 1:20 AM
Unknown Object (File)
Mon, Jun 15, 4:15 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 24 2024, 8:45 PM

Rebase after dropping the addition of the dwarf 3 symbols. Just note it here
since it has the same effect in one fewer changes.

I would call the script debuginfo.ldscript instead of debug.

sys/conf/debug.ldscript
8 ↗(On Diff #134958)

Is this still relevant?

sys/conf/debug.ldscript
8 ↗(On Diff #134958)

Likely not.

sys/conf/debug.ldscript
8 ↗(On Diff #134958)

Likely not.

Since we have them in the vdso_*.ldscript files, maybe we should remove them from there too?

sys/conf/debug.ldscript
8 ↗(On Diff #134958)

Could you point me specifically at the place where in vdso scripts we include stabs?

sys/conf/debug.ldscript
8 ↗(On Diff #134958)

No. We have .comment there

Drop .comment...
Maybe it should be discard?

sys/conf/debug.ldscript
8 ↗(On Diff #134958)

Ah, we explicitly discard it there... my mistake.

I still think that the script should be renamed to 'debuginfo'.

In D44071#1007601, @kib wrote:

I still think that the script should be renamed to 'debuginfo'.

Ah yes. That detail slipped through the cracks. Will correct and respin

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2024, 4:24 AM
This revision was automatically updated to reflect the committed changes.