Page MenuHomeFreeBSD

kernel: Move the debug stuff into a common script
Needs ReviewPublic

Authored by imp on Feb 24 2024, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 7:29 AM
Unknown Object (File)
Sun, Apr 14, 5:42 PM
Unknown Object (File)
Sun, Apr 14, 12:39 PM
Unknown Object (File)
Mon, Apr 8, 10:40 PM
Unknown Object (File)
Mon, Apr 8, 10:34 PM
Unknown Object (File)
Mon, Apr 8, 12:01 PM
Unknown Object (File)
Mon, Apr 8, 11:08 AM
Unknown Object (File)
Mar 13 2024, 6:23 AM
Subscribers

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56350
Build 53238: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 24 2024, 8:45 PM

Rebase after dropping the addition of the dwarf 3 symbols. Just note it here
since it has the same effect in one fewer changes.

I would call the script debuginfo.ldscript instead of debug.

sys/conf/debug.ldscript
9

Is this still relevant?

sys/conf/debug.ldscript
9

Likely not.

sys/conf/debug.ldscript
9

Likely not.

Since we have them in the vdso_*.ldscript files, maybe we should remove them from there too?

sys/conf/debug.ldscript
9

Could you point me specifically at the place where in vdso scripts we include stabs?

sys/conf/debug.ldscript
9

No. We have .comment there

Drop .comment...
Maybe it should be discard?

sys/conf/debug.ldscript
9

Ah, we explicitly discard it there... my mistake.

I still think that the script should be renamed to 'debuginfo'.

In D44071#1007601, @kib wrote:

I still think that the script should be renamed to 'debuginfo'.

Ah yes. That detail slipped through the cracks. Will correct and respin