Page MenuHomeFreeBSD
Differential D44071

kernel: Move the debug stuff into a common script
Needs ReviewPublic
Actions

Authored by imp on Feb 24 2024, 8:45 PM.
Tags
None
Referenced Files
F83390556: D44071.diff
Thu, May 9, 8:16 PM
Unknown Object (File)
Sun, Apr 21, 7:29 AM
Unknown Object (File)
Sun, Apr 14, 5:42 PM
Unknown Object (File)
Sun, Apr 14, 12:39 PM
Unknown Object (File)
Apr 8 2024, 10:40 PM
Unknown Object (File)
Apr 8 2024, 10:34 PM
Unknown Object (File)
Apr 8 2024, 12:01 PM
Unknown Object (File)
Apr 8 2024, 11:08 AM
View All 10 Files
Subscribers
emaste

Details

Reviewers
markj
kib
jrtc27
kevans
andrew
emaste
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56228
Build 53116: arc lint + arc unit

Event Timeline

imp created this revision.Feb 24 2024, 8:45 PM
Herald added a reviewer: andrew. · View Herald TranscriptFeb 24 2024, 8:45 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
imp requested review of this revision.Feb 24 2024, 8:45 PM
Harbormaster completed remote builds in B56226: Diff 134956.Feb 24 2024, 8:45 PM
imp added a parent revision: D44070: kernel: Bring DWARF3 symbols to all kernels.Feb 24 2024, 8:45 PM
imp added a child revision: D44072: kernel: Add new dwarf symbols.
imp added a reviewer: emaste.Feb 24 2024, 8:47 PM
imp updated this revision to Diff 134958.Feb 24 2024, 9:05 PM

Rebase after dropping the addition of the dwarf 3 symbols. Just note it here
since it has the same effect in one fewer changes.

Harbormaster completed remote builds in B56228: Diff 134958.Feb 24 2024, 9:05 PM
imp edited parent revisions, added: D44069: kernel: Sync ldscript files wrt gnu.attributes and .note.GNU-stack; removed: D44070: kernel: Bring DWARF3 symbols to all kernels.Feb 24 2024, 9:08 PM
kib added a comment.Feb 24 2024, 9:16 PM

I would call the script debuginfo.ldscript instead of debug.

sys/conf/debug.ldscript
8

Is this still relevant?

imp added inline comments.Feb 24 2024, 9:18 PM
sys/conf/debug.ldscript
8

Likely not.

imp added inline comments.Feb 24 2024, 9:22 PM
sys/conf/debug.ldscript
8

Likely not.

Since we have them in the vdso_*.ldscript files, maybe we should remove them from there too?

kib added inline comments.Feb 24 2024, 9:29 PM
sys/conf/debug.ldscript
8

Could you point me specifically at the place where in vdso scripts we include stabs?

imp added inline comments.Feb 24 2024, 9:32 PM
sys/conf/debug.ldscript
8

No. We have .comment there

imp updated this revision to Diff 134964.Feb 25 2024, 12:53 AM

Drop .comment...
Maybe it should be discard?

Harbormaster completed remote builds in B56232: Diff 134964.Feb 25 2024, 12:53 AM
imp added inline comments.Feb 25 2024, 2:01 AM
sys/conf/debug.ldscript
8

Ah, we explicitly discard it there... my mistake.

imp updated this revision to Diff 135227.Feb 29 2024, 4:28 PM

Update script

Harbormaster completed remote builds in B56350: Diff 135227.Feb 29 2024, 4:28 PM
kib added a comment.Mar 1 2024, 7:31 AM

I still think that the script should be renamed to 'debuginfo'.

imp added a comment.Mar 1 2024, 3:25 PM
In D44071#1007601, @kib wrote:

I still think that the script should be renamed to 'debuginfo'.

Ah yes. That detail slipped through the cracks. Will correct and respin

Revision Contents
Changeset List

Diff 134958

View Options

sys/conf/debug.ldscript

Loading...
View Options

sys/conf/kern.pre.mk

Loading...
View Options

sys/conf/ldscript.amd64

Loading...
View Options

sys/conf/ldscript.arm

Loading...
View Options

sys/conf/ldscript.arm64

Loading...
View Options

sys/conf/ldscript.i386

Loading...
View Options

sys/conf/ldscript.powerpc

Loading...
View Options

sys/conf/ldscript.powerpc64

Loading...
View Options

sys/conf/ldscript.powerpc64le

Loading...
View Options

sys/conf/ldscript.powerpcspe

Loading...
View Options

sys/conf/ldscript.riscv

Loading...