Page MenuHomeFreeBSD

uniq: Replace NetBSD's unit tests with our own.
ClosedPublic

Authored by des on Jan 9 2024, 8:28 PM.
Tags
None
Referenced Files
F102613883: D43381.diff
Thu, Nov 14, 7:56 PM
F102613329: D43381.diff
Thu, Nov 14, 7:43 PM
Unknown Object (File)
Tue, Oct 29, 11:56 PM
Unknown Object (File)
Oct 8 2024, 11:18 AM
Unknown Object (File)
Sep 29 2024, 11:16 AM
Unknown Object (File)
Sep 29 2024, 9:29 AM
Unknown Object (File)
Sep 21 2024, 9:32 PM
Unknown Object (File)
Sep 6 2024, 6:12 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jan 9 2024, 8:28 PM
ObsoleteFiles.inc
54

maybe "switch from NetBSD uniq tests to our own" or some other hint as to why new tests are removing a bunch of files?

usr.bin/uniq/tests/uniq_test.sh
8

This has no special meaning to atf, right? Because of the atf prefix I thought it might.

9–12

it took me a moment to reason about the different cases here, maybe a comment that this is covering the various combinations of [input_file [output_file]]?

Should we test uniq "$@" input actual as well?

31

perhaps test input that doesn't have the same count for each line of output?

des marked an inline comment as done.

incorporate suggestions

des marked 2 inline comments as done.Jan 10 2024, 3:24 PM
des added inline comments.
usr.bin/uniq/tests/uniq_test.sh
8

No, no special meaning, it just seemed like the appropriate name for a function that literally runs atf_check uniq.

des marked an inline comment as done.Jan 10 2024, 3:24 PM
This revision is now accepted and ready to land.Jan 10 2024, 3:28 PM

improve test case for -cd

This revision now requires review to proceed.Jan 11 2024, 4:24 PM
This revision is now accepted and ready to land.Jan 11 2024, 4:29 PM
This revision now requires review to proceed.Jan 11 2024, 4:36 PM
This revision is now accepted and ready to land.Jan 11 2024, 4:38 PM
This revision was automatically updated to reflect the committed changes.