Page MenuHomeFreeBSD
Differential D42274

pmap: Prefer consistent naming for loader tunable
ClosedPublic
Actions

Authored by zlei on Oct 18 2023, 10:25 AM.
Tags
None
Referenced Files
F170555163: D42274.diff
Sat, Sep 5, 9:37 AM
Unknown Object (File)
Fri, Sep 4, 11:58 AM
Unknown Object (File)
Sun, Aug 30, 9:02 AM
Unknown Object (File)
Thu, Aug 13, 12:04 PM
Unknown Object (File)
Sun, Aug 9, 12:55 PM
Unknown Object (File)
Sun, Aug 9, 12:54 PM
Unknown Object (File)
Fri, Aug 7, 8:06 PM
Unknown Object (File)
Thu, Aug 6, 2:40 PM
View All Files
Subscribers
imp
jhibbits

Details

Reviewers
alc
peter
kib
andrew
jhibbits
Commits
rG0ceaf5d46282: pmap: Prefer consistent naming for loader tunable
rG16afc2a4d9c5: pmap: Prefer consistent naming for loader tunable
rGe53f8ca323e8: pmap: Prefer consistent naming for loader tunable
rG02320f642095: pmap: Prefer consistent naming for loader tunable
Summary

The sysctl knob 'vm.pmap.pv_entry_max' becomes a loader tunable since
7ff48af7040f (Allow a specific setting for pv entries) but with a
different system environment 'vm.pmap.pv_entries'. That is inconsistent
and obscure.

This revert 36e1b9702e21 (Correct the tunable name in the message).

PR: 231577
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Oct 18 2023, 10:25 AM
Herald added a reviewer: andrew. · View Herald TranscriptOct 18 2023, 10:25 AM
Herald added subscribers: jhibbits, imp. · View Herald Transcript
zlei requested review of this revision.Oct 18 2023, 10:25 AM
zlei edited the summary of this revision. (Show Details)
zlei added a comment.Oct 18 2023, 10:31 AM

I personally dislike this back and forth ;(

zlei added a parent revision: D42233: amd64: Add sysctl knobs for loader tunables.Oct 18 2023, 10:32 AM
jhibbits accepted this revision.Oct 18 2023, 2:37 PM
This revision is now accepted and ready to land.Oct 18 2023, 2:37 PM
alc accepted this revision.Oct 18 2023, 4:01 PM
kib accepted this revision.Oct 18 2023, 4:27 PM
Closed by commit rG02320f642095: pmap: Prefer consistent naming for loader tunable (authored by zlei). · Explain WhyOct 19 2023, 5:02 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG02320f642095: pmap: Prefer consistent naming for loader tunable.
zlei added a child revision: D42311: amd64 pmap: Prefer consistent naming for loader tunable.Oct 20 2023, 8:31 AM
zlei added a commit: rGe53f8ca323e8: pmap: Prefer consistent naming for loader tunable.Oct 23 2023, 10:13 AM
zlei added a commit: rG16afc2a4d9c5: pmap: Prefer consistent naming for loader tunable.Oct 23 2023, 10:17 AM
zlei added a commit: rG0ceaf5d46282: pmap: Prefer consistent naming for loader tunable.

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
4 lines
i386/
i386/
4 lines
powerpc/
booke/
2 lines

Diff 129118

View Options

sys/arm/arm/pmap-v6.c

Loading...
View Options

sys/i386/i386/pmap.c

Loading...
View Options

sys/powerpc/booke/pmap.c

Loading...