Page MenuHomeFreeBSD

x86: Prefer consistent naming for loader tunables
ClosedPublic

Authored by zlei on Oct 17 2023, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 4:40 PM
Unknown Object (File)
Wed, May 1, 6:07 PM
Unknown Object (File)
Sat, Apr 27, 12:11 PM
Unknown Object (File)
Fri, Apr 26, 9:08 PM
Unknown Object (File)
Fri, Apr 26, 6:45 AM
Unknown Object (File)
Fri, Apr 26, 6:45 AM
Unknown Object (File)
Fri, Apr 26, 12:17 AM
Unknown Object (File)
Thu, Apr 25, 11:58 PM
Subscribers

Details

Summary

The following loader tunables do have corresponding sysctl MIBs but
with inconsistent naming. That may be historical reason. Let's prefer
consistent naming for them so that the code is easier to read and maintain.

  1. hw.dmar.timeout -> hw.iommu.dmar.timeout
  2. hw.lapic_eoi_suppression -> hw.apic.eoi_suppression
  3. hw.lapic_tsc_deadline -> hw.apic.timer_tsc_deadline
  4. hw.x2apic_enable -> hw.apic.x2apic_mode

Those tunables are for field debugging, no need to keep old names for
compatibility.

MFC after: 5 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Oct 17 2023, 8:06 AM
zlei retitled this revision from x86: Various fixes for loader tunables to x86: Prefer consistent naming for loader tunables.Oct 17 2023, 9:57 AM
zlei added a reviewer: kib.
sys/x86/x86/local_apic.c
213

@kib Are these for debugging only ?

If yes I think there's no need to flag them with CTLFLAG_TUN.

496

If yes I think there's no need to flag them with CTLFLAG_TUN.

Then no need for backward compatibility.

Do not provide backward compat for these knobs. They are for field debugging.

zlei edited the summary of this revision. (Show Details)

Removed CTLFLAG_TUN, dropped code for compatibility.

This revision is now accepted and ready to land.Oct 20 2023, 3:47 PM