Page MenuHomeFreeBSD

vmx: Prefer consistent naming for loader tunables
ClosedPublic

Authored by zlei on Oct 17 2023, 9:25 AM.
Tags
None
Referenced Files
F132456983: D42251.diff
Fri, Oct 17, 2:29 AM
Unknown Object (File)
Sun, Oct 12, 5:23 AM
Unknown Object (File)
Sun, Oct 12, 2:21 AM
Unknown Object (File)
Tue, Oct 7, 11:40 PM
Unknown Object (File)
Sep 15 2025, 12:58 PM
Unknown Object (File)
Sep 14 2025, 8:19 PM
Unknown Object (File)
Aug 25 2025, 4:23 AM
Unknown Object (File)
Aug 23 2025, 11:46 AM
Subscribers

Details

Summary

The following loader tunables does have corresponding sysctl MIBs but
with inconsistent naming. That may be historical reason. Let's prefer
consistent naming for them so that they will be easier to read and
maintained.

  1. hw.vmm.l1d_flush -> hw.vmm.vmx.l1d_flush
  2. hw.vmm.l1d_flush_sw -> hw.vmm.vmx.l1d_flush_sw
  3. hw.vmm.vmx.use_apic_pir -> hw.vmm.vmx.cap.posted_interrupts
  4. hw.vmm.vmx.use_apic_vid -> hw.vmm.vmx.cap.virtual_interrupt_delivery
  5. hw.vmm.vmx.use_tpr_shadowing -> hw.vmm.vmx.cap.tpr_shadowing

Old names are kept for compatibility.

Meanwhile, add sysctl flag CTLFLAG_TUN to them so that sysctl -T will
report them correctly.

MFC after: 1 week

Test Plan

On Intel x64 platform, load vmm kernel modules and verify the loader tunables.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Oct 17 2023, 9:25 AM
This revision is now accepted and ready to land.Oct 17 2023, 1:58 PM