Paths

Table of Contentst

Differential D4215

Fix GIC interrupts decoding in FDT
ClosedPublic
Actions

Authored by bsz_semihalf.com on Nov 19 2015, 12:26 PM.

Tags

Referenced Files

	F106162655: D4215.id10376.diff
	Thu, Dec 26, 10:22 AM

	Unknown Object (File)
	Fri, Dec 13, 12:00 PM

	Unknown Object (File)
	Wed, Dec 11, 11:24 PM

	Unknown Object (File)
	Wed, Dec 4, 7:58 AM

	Unknown Object (File)
	Tue, Dec 3, 2:27 PM

	Unknown Object (File)
	Oct 20 2024, 12:41 PM

	Unknown Object (File)
	Sep 24 2024, 4:22 AM

	Unknown Object (File)
	Sep 23 2024, 3:45 AM

View All 76 Files

Subscribers

Details

Reviewers

imp
• ian

Commits

rS294422: Fix GIC FDT interrupts decoding

Summary

Interrupt type in FDT was interpreted incorrectly.
Patch taken from freebsd-arm thread 'GIC - interrupts interpretation in
DTS/FDT':
https://lists.freebsd.org/pipermail/freebsd-arm/2015-August/012145.html

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Michal Stanek <mst@semihalf.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bsz_semihalf.com updated this revision to Diff 10343.Nov 19 2015, 12:26 PM

bsz_semihalf.com retitled this revision from to Fix GIC interrupts decoding in FDT.

bsz_semihalf.com updated this object.

bsz_semihalf.com edited the test plan for this revision. (Show Details)

bsz_semihalf.com added reviewers: • ian, imp.

bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

bsz_semihalf.com added a project: ARM.

bsz_semihalf.com added a subscriber: zbb.

Herald added a subscriber: andrew. · View Herald TranscriptNov 19 2015, 12:26 PM

bsz_semihalf.com added a parent revision: D4214: Use GIC-specific decoding function in mv_common.c.Nov 19 2015, 12:26 PM

bsz_semihalf.com added a child revision: D4216: Add compatibility string for dw-apb-uart in ns8250 driver.

imp accepted this revision.Nov 19 2015, 2:48 PM

imp edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2015, 2:48 PM

andrew added inline comments.Nov 19 2015, 2:54 PM

sys/arm/arm/gic.c
339–341	You should follow style(9) here, new line agter the `&&`

Style corrected.

This revision now requires review to proceed.Nov 20 2015, 1:45 PM

• ian added inline comments.Dec 9 2015, 11:08 PM

sys/arm/arm/gic.c
118	This is a horrible name, all 4 bits are trigger bits, the distinction is between edge and level triggering. How about something like GIC_FDT_EDGE_TRIGGERED? (or _EDGE_BITS).

bsz_semihalf.com added inline comments.Dec 10 2015, 10:11 AM

sys/arm/arm/gic.c
118	Somebody fixed that already in tree, so I will remove it.

bsz_semihalf.com updated this revision to Diff 11104.Dec 11 2015, 12:47 PM

bsz_semihalf.com edited edge metadata.

bsz_semihalf.com marked 2 inline comments as done.

• ian accepted this revision.Dec 22 2015, 3:49 AM

• ian edited edge metadata.

This revision is now accepted and ready to land.Dec 22 2015, 3:49 AM

Closed by commit rS294422: Fix GIC FDT interrupts decoding (authored by zbb). · Explain WhyJan 20 2016, 1:46 PM

This revision was automatically updated to reflect the committed changes.

bsz_semihalf.com mentioned this in D5029: Fix GIC interrupt decoding in INTRNG code.Jan 22 2016, 10:16 AM

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

10 lines

Diff 10376

sys/arm/arm/gic.c

Loading...