Change dts entry of PCIe controller for Armada38x
ClosedPublic
Actions

Authored by bsz_semihalf.com on Dec 4 2015, 1:19 PM.

Details

Reviewers

imp
• ian

Commits

rS294432: Change DTS entry of PCIe controller for Armada38x

Summary

Invalid (in FreeBSD) definition of PCI controller taken from Linux was
replaced with another one, working in FreeBSD environment.

PCI controller's entry had to move from its parent node so as to be
recognized properly by FBSD.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <bsz@semihalf.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bsz_semihalf.com updated this revision to Diff 10739.Dec 4 2015, 1:19 PM

bsz_semihalf.com retitled this revision from to Change dts entry of PCIe controller for Armada38x.

bsz_semihalf.com updated this object.

bsz_semihalf.com edited the test plan for this revision. (Show Details)

bsz_semihalf.com added reviewers: • ian, imp.

bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

bsz_semihalf.com added a project: ARM.

bsz_semihalf.com added a subscriber: zbb.

Herald added a subscriber: andrew. · View Herald TranscriptDec 4 2015, 1:19 PM

bsz_semihalf.com added a child revision: D4380: Correct MV_DDR_CADR_BASE definiton in mvwin.h.Dec 4 2015, 2:10 PM

bsz_semihalf.com added a parent revision: D4378: Enhance definitions of CPU/PCIe windows for Armada38x.

bsz_semihalf.com updated this revision to Diff 10859.Dec 7 2015, 8:40 AM

Why not fix the code?

In D4379#94451, @andrew wrote:

Why not fix the code?

I understand the driver should eventually be made fully compatible with Linux DTS, but as for now improving it is beyond time and effort I can make. Especially that format used in these nodes differs significantly. Please note that your remark applies to all platforms using this driver, including ARMADAXP, DB-88F6XXX and DB-78XXX.

Therefore I think that commit improving compatbility in PCI driver should be considered as seperate, to-do task.

bsz_semihalf.com updated this revision to Diff 12049.Jan 8 2016, 3:04 PM

Closed by commit rS294432: Change DTS entry of PCIe controller for Armada38x (authored by zbb). · Explain WhyJan 20 2016, 2:14 PM

This revision was automatically updated to reflect the committed changes.