Add interrupt line for EHCI USB errors in Armada38x

[bsz_semihalf.com]

Summary

FreeBSD EHCI driver for Marvell platforms requires dedicated interrupt lines
for error handling. USB2.0 attaches and works properly after this commit.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <[e-mail]>

[andrew]

Why is this not part of D4210?

[bsz_semihalf.com]

andrew, we decided to do raw import from Linux in first commit, and then introduce all neccessary changes explicitly in seperate commits.

[andrew]

So why don't you fix the code to only need one interrupt in this case?

[bsz_semihalf.com]

Interrupt line for errors exists in hardware and is documented Armada38x family functional specifications, so better to say that dts was incomplete, than the code needed fix.

[• ian]

This makes our local copy of the dts different than the published linux copy, that seems like a step in the wrong direction. The linux driver must be able to work without this interrupt? (I hate that linux just leaves hardware descriptions out of dts files if their driver doesn't care about that detail, is that the case here?)

[bsz_semihalf.com]

In D4370#94235, @ian wrote:

This makes our local copy of the dts different than the published linux copy, that seems like a step in the wrong direction. The linux driver must be able to work without this interrupt? (I hate that linux just leaves hardware descriptions out of dts files if their driver doesn't care about that detail, is that the case here?)

Exactly, the interrupt is in hardware but Linux doesn't need it. Our driver needed, but I changed it according to Andrew's remarks: https://reviews.freebsd.org/D4369
So as for now this commit is not neccessary, I'll try to close it.

[bsz_semihalf.com]

D4369 solved the issue.