Page MenuHomeFreeBSD

Use GIC-specific decoding function in mv_common.c
ClosedPublic

Authored by bsz_semihalf.com on Nov 19 2015, 12:24 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Apr 23, 1:19 PM
Unknown Object (File)
Tue, Apr 9, 4:05 AM
Unknown Object (File)
Tue, Apr 9, 12:58 AM
Unknown Object (File)
Feb 13 2024, 10:56 PM
Unknown Object (File)
Feb 12 2024, 10:59 AM
Unknown Object (File)
Feb 8 2024, 6:16 PM
Unknown Object (File)
Dec 19 2023, 11:48 PM
Unknown Object (File)
Dec 9 2023, 7:50 PM
Subscribers

Details

Summary

Add gic_decode_fdt function to fdt_pic_table, allowing to recognize GIC
interrupts on Armada38x. SOC_MV_ARMADA38X ifdef is required because A38X
is the only Marvell's platform in FreeBSD using GIC; lack of ifdef would
lead to linking errors on other platforms.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Michal Stanek <mst@semihalf.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bsz_semihalf.com retitled this revision from to Use GIC-specific decoding function in mv_common.c.
bsz_semihalf.com updated this object.
bsz_semihalf.com edited the test plan for this revision. (Show Details)
bsz_semihalf.com added reviewers: ian, imp.
bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
bsz_semihalf.com added a project: ARM.
bsz_semihalf.com added a subscriber: zbb.
imp edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2015, 2:47 PM

I think you wouldn't need this if you enabled ARM_INTRNG for the platform, wouldn't that be a better way to go?

In D4214#94222, @ian wrote:

I think you wouldn't need this if you enabled ARM_INTRNG for the platform, wouldn't that be a better way to go?

I'm working on ARM_INTRNG on this platform on current, it's almost ready. So it's up to you if you want this commit in tree. Personally, I think it's better to have a fallback solution working, but that's not really required.

sys/arm/mv/mv_common.c
2187–2190 ↗(On Diff #10342)

Why not add gic_decode_fdt to fdt_pic_table?

bsz_semihalf.com updated this object.
bsz_semihalf.com edited edge metadata.

Added gic_decode_fdt to fdt_pic_table instead.

This revision now requires review to proceed.Dec 11 2015, 12:42 PM
andrew added a reviewer: andrew.
This revision is now accepted and ready to land.Dec 11 2015, 3:36 PM
ian edited edge metadata.
In D4214#94222, @ian wrote:

I think you wouldn't need this if you enabled ARM_INTRNG for the platform, wouldn't that be a better way to go?

I'm working on ARM_INTRNG on this platform on current, it's almost ready. So it's up to you if you want this commit in tree. Personally, I think it's better to have a fallback solution working, but that's not really required.

Good point, having a fallback is good idea, and easy to do.

This revision was automatically updated to reflect the committed changes.