Page MenuHomeFreeBSD

Add global mpcore timer node to dts
ClosedPublic

Authored by bsz_semihalf.com on Nov 19 2015, 12:22 PM.
Tags
Referenced Files
Unknown Object (File)
Nov 13 2024, 10:37 AM
Unknown Object (File)
Nov 13 2024, 5:43 AM
Unknown Object (File)
Nov 9 2024, 6:50 PM
Unknown Object (File)
Nov 4 2024, 11:52 AM
Unknown Object (File)
Oct 22 2024, 11:40 AM
Unknown Object (File)
Oct 22 2024, 11:40 AM
Unknown Object (File)
Oct 22 2024, 11:40 AM
Unknown Object (File)
Oct 22 2024, 11:40 AM
Subscribers

Details

Summary

Add global mpcore timer node to dts

Changes:

  • global mpcore timer dts node added
  • required by driver 'clock-frequency' property added

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <bsz@semihalf.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bsz_semihalf.com retitled this revision from to Enhance mpcore timers dts entry for Armada38x.
bsz_semihalf.com updated this object.
bsz_semihalf.com edited the test plan for this revision. (Show Details)
bsz_semihalf.com added reviewers: ian, imp.
bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
bsz_semihalf.com added a project: ARM.
bsz_semihalf.com added a subscriber: zbb.

I'm curious why you didn't just add the arm,cortex-a9-twd-timer compat string to the mpcore driver? I notice in the driver it says it's a little non-standard, but it looks fairly close to the standard bindings these days.

In D4213#88861, @imp wrote:

I'm curious why you didn't just add the arm,cortex-a9-twd-timer compat string to the mpcore driver? I notice in the driver it says it's a little non-standard, but it looks fairly close to the standard bindings these days.

"arm,cortex-a9-twd-timer" is already present in the driver. There is difference in functionality between this and "arm,mpcore-timers", though. The first one implements only private timer (TMR_PRV), while the second one enables both private and global timer (TMR_BOTH). We need both timers (and both are available on our platform), so we enhanced the dts file.

This isn't really the right way to do this, arm,mpcore-timers is a non-standard thing we made up in freebsd and we should stop using it.

I think the more-correct way to do this is add a new device node with compatible="arm,cortex-a9-global-timer" and reg=<0xc200 0x100> and leave the existing node as-is.

bsz_semihalf.com retitled this revision from Enhance mpcore timers dts entry for Armada38x to Add global mpcore timer node to dts.
bsz_semihalf.com updated this object.
bsz_semihalf.com edited edge metadata.

Seperated nodes according to Ian's remark.

ian edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 3:47 AM
This revision was automatically updated to reflect the committed changes.