Enhance attachment of ehci_mv driver

[bsz_semihalf.com]

Summary

Driver was modified to ensure it attaches properly to "marvell,orion-ehci"
node, which doesn't have error interrupt line defined. Neccessary
ofw_compat_data struct was added and probe procedure was altered.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <[e-mail]>

[andrew]

Based on discussions in D4370 this is not compatible with the marvell,orion-ehci bindings. Can you either fix this, or mark the device in the device tree in such a way we could later fix the driver to use the upstream bindings. My preference is for the former as it makes it easier to use the same dts as Linux.

[bsz_semihalf.com]

Added conditions for "marvell,orion-ehci" case, in which driver shouldn't attach interrupt line for errors.

[bsz_semihalf.com]

andrew, I updated the diff. Please let me know if this is solution you expected.

[andrew]

Is D4370 needed with this version?

[bsz_semihalf.com]

No. I just don't know how to mark it outdated on Phabricator.

[andrew]

In D4369#94435, @bsz_semihalf.com wrote:

No. I just don't know how to mark it outdated on Phabricator.

There is an option to abandon a change in the Action drop down menu.

[bsz_semihalf.com]

Sure, thank you :)

[bsz_semihalf.com]

@ian, @imp, would you mind to review this and following commits? Or can we commit with approval of only one of reviewers?

[• ian]

In D4369#102633, @bsz_semihalf.com wrote:

@ian, @imp, would you mind to review this and following commits? Or can we commit with approval of only one of reviewers?

I've always considered any one reviewer approval good enough (although I try to wait long enough to let other reviews add comments if they want).