Page MenuHomeFreeBSD
Differential D4377

Fix invalid root link detection in mv_pci driver
ClosedPublic
Actions

Authored by bsz_semihalf.com on Dec 4 2015, 1:15 PM.
Tags
Referenced Files
Unknown Object (File)
Oct 28 2024, 6:17 AM
Unknown Object (File)
Oct 22 2024, 11:38 AM
Unknown Object (File)
Oct 22 2024, 11:38 AM
Unknown Object (File)
Oct 22 2024, 11:38 AM
Unknown Object (File)
Oct 22 2024, 11:38 AM
Unknown Object (File)
Oct 22 2024, 11:38 AM
Unknown Object (File)
Oct 22 2024, 11:25 AM
Unknown Object (File)
Sep 24 2024, 9:26 AM
View All 87 Files
Subscribers
andrew
zbb

Details

Reviewers
andrew
imp
• ian
Commits
rS294430: Fix invalid root link detection in mv_pci driver
Summary

mv_pci driver omitted slot 0, which can be valid device on Armada38x. New
mechanism detects if device is root link, basing on vendor's and device's
IDs. It is restricted to Armada38x; on other machines, behaviour remains
the same.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <bsz@semihalf.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bsz_semihalf.com updated this revision to Diff 10737.Dec 4 2015, 1:15 PM
bsz_semihalf.com retitled this revision from to Fix invalid root link detection in mv_pci driver.
bsz_semihalf.com updated this object.
bsz_semihalf.com edited the test plan for this revision. (Show Details)
bsz_semihalf.com added reviewers: • ian, imp.
bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
bsz_semihalf.com added a project: ARM.
bsz_semihalf.com added a subscriber: zbb.
Herald added a subscriber: andrew. · View Herald TranscriptDec 4 2015, 1:15 PM
bsz_semihalf.com added a child revision: D4378: Enhance definitions of CPU/PCIe windows for Armada38x.Dec 4 2015, 2:11 PM
bsz_semihalf.com added a parent revision: D4376: Enhance remap capabilities for Armada38x.
bsz_semihalf.com updated this revision to Diff 10857.Dec 7 2015, 8:39 AM
andrew added inline comments.Dec 10 2015, 9:36 AM
sys/arm/mv/mv_pci.c
1032 ↗(On Diff #10857)

This should be #else with the #endif after the return below.

bsz_semihalf.com updated this revision to Diff 11105.Dec 11 2015, 12:54 PM

Added #else.

bsz_semihalf.com marked an inline comment as done.Dec 11 2015, 12:55 PM
andrew accepted this revision.Dec 11 2015, 3:39 PM
andrew added a reviewer: andrew.
This revision is now accepted and ready to land.Dec 11 2015, 3:39 PM
Closed by commit rS294430: Fix invalid root link detection in mv_pci driver (authored by zbb). · Explain WhyJan 20 2016, 2:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
mv/
25 lines
1 line
dev/
pci/
3 lines

Diff 12508

View Options

head/sys/arm/mv/mv_pci.c

Loading...
View Options

head/sys/arm/mv/mvreg.h

Loading...
View Options

head/sys/dev/pci/pcireg.h

Loading...