Add global mpcore timer node to dts
Changes:
- global mpcore timer dts node added
- required by driver 'clock-frequency' property added
Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <bsz@semihalf.com>
Differential D4213
Add global mpcore timer node to dts bsz_semihalf.com on Nov 19 2015, 12:22 PM. Authored by Tags Referenced Files
Details
Add global mpcore timer node to dts Changes:
Obtained from: Semihalf
Diff Detail
Event TimelineComment Actions I'm curious why you didn't just add the arm,cortex-a9-twd-timer compat string to the mpcore driver? I notice in the driver it says it's a little non-standard, but it looks fairly close to the standard bindings these days. Comment Actions "arm,cortex-a9-twd-timer" is already present in the driver. There is difference in functionality between this and "arm,mpcore-timers", though. The first one implements only private timer (TMR_PRV), while the second one enables both private and global timer (TMR_BOTH). We need both timers (and both are available on our platform), so we enhanced the dts file. Comment Actions This isn't really the right way to do this, arm,mpcore-timers is a non-standard thing we made up in freebsd and we should stop using it. I think the more-correct way to do this is add a new device node with compatible="arm,cortex-a9-global-timer" and reg=<0xc200 0x100> and leave the existing node as-is. |