syslogd: Replace int with bool, where applicable

[jfree]

Summary

Many of syslogd's global configuration options are declared as integers
but are treated as booleans. Declare those options as booleans instead.

[emaste]

In future when uploading patches via the web interface please generate them with -U99999 so that Phabricator can show full context (see https://wiki.freebsd.org/Phabricator for details)

[emaste]

Debug might make sense as an int again in the future if we want to support different debug levels, but bool makes sense right now.

[jfree]

The needdofsync global variable was initialized as true, when it should be false. Fix this.

[jfree]

In D41362#941850, @emaste wrote:

In future when uploading patches via the web interface please generate them with -U99999 so that Phabricator can show full context (see https://wiki.freebsd.org/Phabricator for details)

Oops! Thought I did. Just regenerated the patches. Will upload with more context from here on.

[emaste]

The needdofsync global variable was initialized as true, when it should be false. Fix this.

We may want to just leave the 0/false globals without explicit initialization.

[jfree]

In D41362#942043, @emaste wrote:

The needdofsync global variable was initialized as true, when it should be false. Fix this.

We may want to just leave the 0/false globals without explicit initialization.

I just carried over syslogd's code, translating 0 to false and 1 to true.

I believe I address your suggestion in a later patch.

[emaste]

I just carried over syslogd's code, translating 0 to false and 1 to true.

Yeah, certainly if we're going to remove the 0/false initialization it would be done in a prior or subsequent commit

[jfree]

Update after rebase

[emaste]

usr.sbin/syslogd/syslogd.c

392

this one remains int but uses true?

[jfree]

Do not assign boolean value to integer mask_C1