Differential D41170

e1000: fixes for lem(4) and em(4) TSO
ClosedPublic
Actions

Authored by kbowling on Jul 25 2023, 3:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 8:41 PM

	Unknown Object (File)
	Mon, Nov 18, 8:34 PM

	Unknown Object (File)
	Mon, Nov 18, 8:32 PM

	Unknown Object (File)
	Wed, Nov 13, 6:46 AM

	Unknown Object (File)
	Tue, Nov 12, 4:58 AM

	Unknown Object (File)
	Mon, Nov 11, 9:46 PM

	Unknown Object (File)
	Fri, Nov 8, 9:21 AM

	Unknown Object (File)
	Fri, Nov 8, 3:29 AM

Subscribers

Details

Reviewers

markj
marius
shurd

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Commits

rGb8e5efdd24b0: e1000: Some fixes for hardware capabilities
rGc68db90db192: e1000: Automask TSO on lem(4)/em(4) 10/100 Ethernet
rGe9cd4a8fee58: e1000: Fix lem(4)/em(4) TSO6
rGf1b5488f7bba: e1000: Enable TSO for lem(4) and em(4)
rG2ddf24f8f525: e1000: Automask TSO on lem(4)/em(4) 10/100 Ethernet
rGe1353dcb63bb: e1000: Fix lem(4)/em(4) TSO6

Summary

This patch fixes:

IPv6 TSO on em(4)
Limits TSO to IPv4 on lem(4) based on NetBSD and Linux

Test Plan

Tested on I219, 82541GI, 82546EB, VirtualBox lem(4), qemu lem(4), VMWare lem(4), VMware 82574L

TSO is not enabled on lem(4) or em(4) by default

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Jul 25 2023, 3:35 AM

Owners added a reviewer: Restricted Owners Package.Jul 25 2023, 3:35 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 25 2023, 3:35 AM

kbowling requested review of this revision.Jul 25 2023, 3:35 AM

kbowling added inline comments.Jul 25 2023, 3:38 AM

sys/dev/e1000/em_txrx.c
163	I moved this here to avoid duplicating conditionals for IPv4 vs IPv6 but am open to style suggestion.
sys/dev/e1000/if_em.c
784	According to Linux lem(4) doesn't support IPv6 TSO, but they do enable TSO for IPv4 by default for (>82544, !82547). I can't see any particular reason while TSOv6 doesn't work here but intel has never been clear on all the bugs on the entire family of chips.

kbowling added inline comments.Jul 25 2023, 3:39 AM

sys/dev/e1000/em_txrx.c
198	I added this previously based on reading the SDM noting a slightly different behavior.. but I can't think of why it would matter in reality, because you wouldn't be doing a lower (IP) checksum on IPv6 anyway.

Don't try TSO on 10/100 for lem(4)/em(4)

kbowling added a child revision: D41200: iflib: Move network stack capabilities after device driver init.Jul 26 2023, 7:36 PM

I agree with all of the other changes here.

sys/dev/e1000/em_txrx.c
182	Why add an extra line here?
183–185	I like the addition of the field names to the comment here.

kbowling mentioned this in D41200: iflib: Move network stack capabilities after device driver init.Jul 26 2023, 8:45 PM

shurd added a subscriber: shurd.Jul 27 2023, 10:12 AM

shurd added inline comments.

sys/dev/e1000/if_em.c
1408	Looks like SPEED_1000 (which == 1000 of course). Also, do any types < igb_mac_min support 2500?

erj added inline comments.Jul 27 2023, 3:55 PM

sys/dev/e1000/if_em.c
1408	I think the only device covered by this driver that could possibly support 2500 link speed would be i354, which would be above igb_mac_min.

kbowling updated this revision to Diff 125273.Jul 28 2023, 12:46 AM

kbowling edited the test plan for this revision. (Show Details)

kbowling added reviewers: marius, shurd.

@shurd I added some smarts to the TSO automask. Also added a sysctl for people that want to opt out of.

kbowling marked an inline comment as done.Jul 28 2023, 12:48 AM

kbowling updated this revision to Diff 125274.Jul 28 2023, 2:16 AM

kbowling updated this revision to Diff 125319.Jul 29 2023, 1:21 AM

@shurd updated automask to not require the iflib internal change.

kbowling removed a child revision: D41200: iflib: Move network stack capabilities after device driver init.Jul 29 2023, 5:25 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2023, 3:22 PM

Closed by commit rGe1353dcb63bb: e1000: Fix lem(4)/em(4) TSO6 (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGe1353dcb63bb: e1000: Fix lem(4)/em(4) TSO6.

rebase after committed changes

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG2ddf24f8f525: e1000: Automask TSO on lem(4)/em(4) 10/100 Ethernet.Aug 3 2023, 5:53 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGf1b5488f7bba: e1000: Enable TSO for lem(4) and em(4).Aug 3 2023, 10:36 PM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGe9cd4a8fee58: e1000: Fix lem(4)/em(4) TSO6.Aug 7 2023, 2:36 PM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGc68db90db192: e1000: Automask TSO on lem(4)/em(4) 10/100 Ethernet.Aug 10 2023, 12:28 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGb8e5efdd24b0: e1000: Some fixes for hardware capabilities.Aug 18 2023, 12:57 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

40 lines

9 lines

Diff 125375

sys/dev/e1000/em_txrx.c

Loading...

sys/dev/e1000/if_em.c

Loading...