Page MenuHomeFreeBSD

lib: Enable libcbor and libfido2 for COMPAT_32BIT
ClosedPublic

Authored by jrtc27 on Jul 7 2023, 11:58 PM.
Tags
None
Referenced Files
F102850184: D40920.id124328.diff
Sun, Nov 17, 11:43 PM
Unknown Object (File)
Wed, Nov 6, 1:08 PM
Unknown Object (File)
Wed, Nov 6, 1:08 PM
Unknown Object (File)
Wed, Nov 6, 1:07 PM
Unknown Object (File)
Tue, Nov 5, 12:11 AM
Unknown Object (File)
Wed, Oct 30, 12:35 AM
Unknown Object (File)
Wed, Oct 30, 12:35 AM
Unknown Object (File)
Wed, Oct 30, 12:35 AM
Subscribers

Details

Summary

We no longer have COMPAT_32BIT hacks for libusb, instead supporting the
normal 32-bit ioctls for freebsd32 processes, so we can enable these for
the lib32 build.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 8 2023, 12:31 AM

reference 8010f4ad21b6120e929bda4eed27696e63514677 in the commit message?

I wasn't sure which of the two userspace commits (both?) were relevant, but happy to add the appropriate references if someone tells me which they are

I wasn't sure which of the two userspace commits (both?) were relevant, but happy to add the appropriate references if someone tells me which they are

Fair enough - I was looking to figure out the timeline (when the libusb change happened in relation to my cbor/libfido2 import) and the commit I referenced was the first one I spotted. Mainly I was wondering how long after (or even before, if the changes crossed paths) my work this happened. Perhaps @brooks can suggest the appropriate commit to reference, otherwise I'm fine with leaving it out.