Page MenuHomeFreeBSD

Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make
ClosedPublic

Authored by jrtc27 on Jul 7 2023, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 7:41 AM
Unknown Object (File)
Mon, Oct 13, 7:41 AM
Unknown Object (File)
Mon, Oct 13, 7:41 AM
Unknown Object (File)
Sun, Oct 12, 7:26 PM
Unknown Object (File)
Sat, Oct 4, 2:52 AM
Unknown Object (File)
Mon, Sep 22, 12:37 AM
Unknown Object (File)
Aug 30 2025, 7:44 AM
Unknown Object (File)
Aug 14 2025, 11:16 PM
Subscribers
None

Details

Summary

Currently none of the words in these require quoting, but a future
commit will add words that do, thus we should make sure to quote each
word so the shell doesn't mangle them before calling the sub-make.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.
This revision is now accepted and ready to land.Jul 8 2023, 12:35 AM

LGTM.

This make magic was unfamiliar to me. It may be worth including in the commit message a brief reference to the :@varname@string@ functionality, if you're so inclined.

New make magic to me also.