Differential D40932

bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused
ClosedPublic
Actions

Authored by jrtc27 on Jul 8 2023, 12:03 AM.

Tags

None

Referenced Files

	F168093647: D40932.id124401.diff
	Wed, Aug 26, 8:47 AM

	F168086093: D40932.id124340.diff
	Wed, Aug 26, 7:45 AM

	F168080340: D40932.id.diff
	Wed, Aug 26, 7:05 AM

	Unknown Object (File)
	Wed, Aug 26, 5:57 AM

	Unknown Object (File)
	Wed, Aug 12, 2:21 PM

	Unknown Object (File)
	Tue, Aug 11, 10:00 PM

	Unknown Object (File)
	Mon, Aug 10, 3:32 AM

	Unknown Object (File)
	Sun, Aug 9, 5:05 PM

Subscribers

Details

Reviewers

emaste
imp
brooks
jhb

Commits

rG1840dc06e135: bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jul 8 2023, 12:03 AM

Herald added a subscriber: bdrewery. · View Herald TranscriptJul 8 2023, 12:03 AM

jrtc27 requested review of this revision.Jul 8 2023, 12:03 AM

Harbormaster completed remote builds in B52506: Diff 124340.Jul 8 2023, 12:03 AM

jrtc27 added parent revisions: D40931: lib: Migrate from COMPAT_32BIT to generic COMPAT_LIBCOMPAT, D40930: libsysdecode: Migrate from COMPAT_32BIT to generic COMPAT_LIBCOMPAT, D40929: libiconv_modules: Migrate from COMPAT_32BIT to generic COMPAT_libcompat, D40928: libc: Migrate from COMPAT_32BIT to generic COMPAT_LIBCOMPAT, D40927: geom: Migrate from COMPAT_32BIT to generic COMPAT_libcompat, D40926: kerberos5: Migrate from COMPAT_32BIT to generic COMPAT_LIBCOMPAT, D40925: rtld-elf: Migrate from COMPAT_32BIT to generic COMPAT_libcompat/LIBCOMPAT, D40924: include: Migrate from COMPAT_32BIT to generic COMPAT_libcompat, D40923: openpam: Migrate from COMPAT_32BIT to generic COMPAT_libcompat.Jul 8 2023, 12:06 AM

jrtc27 added a child revision: D40916: libsysdecode: Drop dead __amd64__ && COMPAT_32BIT code.

jrtc27 added a child revision: D40917: Don't bother to check COMPAT_32BIT when __LP64__ is defined.

jrtc27 added a child revision: D40919: rtld-elf: Reuse _BASENAME_RTLD for debug.h rather than duplicating logic.Jul 8 2023, 12:08 AM

jrtc27 added a child revision: D40920: lib: Enable libcbor and libfido2 for COMPAT_32BIT.

jrtc27 removed a child revision: D40916: libsysdecode: Drop dead __amd64__ && COMPAT_32BIT code.

jrtc27 added a parent revision: D40916: libsysdecode: Drop dead __amd64__ && COMPAT_32BIT code.

jrtc27 removed a child revision: D40917: Don't bother to check COMPAT_32BIT when __LP64__ is defined.

jrtc27 added a parent revision: D40917: Don't bother to check COMPAT_32BIT when __LP64__ is defined.

jrtc27 removed a child revision: D40919: rtld-elf: Reuse _BASENAME_RTLD for debug.h rather than duplicating logic.

jrtc27 added a parent revision: D40919: rtld-elf: Reuse _BASENAME_RTLD for debug.h rather than duplicating logic.

jrtc27 removed a child revision: D40920: lib: Enable libcbor and libfido2 for COMPAT_32BIT.

jrtc27 added a parent revision: D40920: lib: Enable libcbor and libfido2 for COMPAT_32BIT.

\o/

This revision is now accepted and ready to land.Jul 8 2023, 12:57 AM

LGTM once prerequisites are done.

It seems the patch sequence doesn't offer a convenient (sensible) place to describe the changes overall / motivation but IMO it would be good to do so, perhaps a mailing list posting that could be referenced from the commits?

Ignore my previous comment, it looks like D40922 is the appropriate one.

If I remember to I'll add a one-line pointer to the committed hash for D40922 in all of these

jrtc27 added a parent revision: D40937: libc: Build all i386 sources for amd64 lib32.Jul 8 2023, 4:59 AM

jhb accepted this revision.Jul 8 2023, 7:45 PM

Closed by commit rG1840dc06e135: bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused (authored by jrtc27). · Explain WhyJul 9 2023, 5:54 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG1840dc06e135: bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused.

Revision Contents
Changeset List

Path

Size

share/

mk/

2 lines

Diff 124401

share/mk/bsd.compat.mk

Loading...