Differential D38046

ifnet/API: Move struct ifnet definition to a <net/if_private.h>
AbandonedPublic
Actions

Authored by jhibbits on Jan 13 2023, 9:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 20 2023, 6:35 AM

	Unknown Object (File)
	Dec 12 2023, 8:09 AM

	Unknown Object (File)
	Nov 15 2023, 5:04 PM

	Unknown Object (File)
	Nov 10 2023, 2:42 AM

	Unknown Object (File)
	Nov 9 2023, 11:46 PM

	Unknown Object (File)
	Nov 1 2023, 7:05 PM

	Unknown Object (File)
	Sep 30 2023, 7:05 PM

	Unknown Object (File)
	Sep 9 2023, 2:16 AM

View All 23 Files

Subscribers

Details

Reviewers

glebius
shurd
melifaro

Group Reviewers

network
iflib

Commits

rG2c2b37ad251d: ifnet/API: Move struct ifnet definition to a <net/if_private.h>

Summary

Hide the ifnet structure definition, no user serviceable parts inside,
it's a netstack implementation detail. Include it temporarily in
<net/if_var.h> until all drivers are updated to use the accessors
exclusively.

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49099
Build 45988: arc lint + arc unit

Event Timeline

jhibbits created this revision.Jan 13 2023, 9:43 PM

Herald added a reviewer: shurd. · View Herald TranscriptJan 13 2023, 9:43 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

jhibbits requested review of this revision.Jan 13 2023, 9:43 PM

Harbormaster completed remote builds in B49099: Diff 115115.Jan 13 2023, 9:43 PM

melifaro added inline comments.Jan 13 2023, 10:56 PM

sys/net/if_private.h
37	You probably want to wrap it into _KERNEL, otherwise buildworld headercheck will be unhappy

jhibbits added inline comments.Jan 14 2023, 1:40 AM

sys/net/if_private.h
37	Good point, will have it in my next update, with any other feedback I get.

glebius accepted this revision as: glebius.Jan 23 2023, 5:13 PM

glebius added inline comments.

sys/net/route/route_rtentry.c
51	This doesn't seem related. If it truly is, why not just remove the line?

jhibbits added inline comments.Jan 23 2023, 5:17 PM

sys/net/route/route_rtentry.c
51	You're right, this include should be removed. The header isn't needed, and this header is the only reason if_private.h would be needed in this file.

jhibbits removed a reviewer: iflib.Jan 23 2023, 6:44 PM

This comment was removed by jhibbits.

This revision is now accepted and ready to land.Jan 23 2023, 6:44 PM

Herald added a reviewer: iflib. · View Herald TranscriptJan 23 2023, 6:44 PM

This revision now requires review to proceed.Jan 23 2023, 6:44 PM

Have to close it somehow.

jhibbits added a commit: rG2c2b37ad251d: ifnet/API: Move struct ifnet definition to a <net/if_private.h>.Sep 7 2023, 12:35 PM

Herald added a reviewer: melifaro. · View Herald TranscriptSep 7 2023, 12:35 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

altq/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

debugnet_inet.c

1 line

ieee8023ad_lacp.c

1 line

1 line

1 line

1 line

1 line

1 line

2 lines

1 line

1 line

1 line

1 line

1 line

1 line

if_infiniband.c

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

1 line

195 lines

1 line

1 line

160 lines

1 line

1 line

1 line

1 line

1 line

1 line

route/

1 line

1 line

1 line

1 line

route_ifaddrs.c

1 line

route_rtentry.c

2 lines

1 line

Diff 115115

sys/net/altq/altq_cbq.c

Loading...

sys/net/altq/altq_codel.c

Loading...

sys/net/altq/altq_fairq.c

Loading...

sys/net/altq/altq_hfsc.c

Loading...

sys/net/altq/altq_priq.c

Loading...

sys/net/altq/altq_rmclass.c

Loading...

sys/net/altq/altq_subr.c

Loading...

sys/net/bpf.c

Loading...

sys/net/bridgestp.c

Loading...

sys/net/debugnet.c

Loading...

sys/net/debugnet_inet.c

Loading...

sys/net/ieee8023ad_lacp.c

Loading...

sys/net/if.c

Loading...

sys/net/if_bridge.c

Loading...

sys/net/if_clone.c

Loading...

sys/net/if_dead.c

Loading...

sys/net/if_disc.c

Loading...

sys/net/if_edsc.c

Loading...

sys/net/if_enc.c

Loading...

sys/net/if_epair.c

Loading...

sys/net/if_ethersubr.c

Loading...

sys/net/if_fwsubr.c

Loading...

sys/net/if_gif.c

Loading...

sys/net/if_gre.c

Loading...

sys/net/if_infiniband.c

Loading...

sys/net/if_ipsec.c

Loading...

sys/net/if_lagg.c

Loading...

sys/net/if_llatbl.c

Loading...

sys/net/if_loop.c

Loading...

sys/net/if_me.c

Loading...

sys/net/if_media.c

Loading...

sys/net/if_mib.c

Loading...

sys/net/if_ovpn.c

Loading...

sys/net/if_private.h

Loading...

sys/net/if_stf.c

Loading...

sys/net/if_tuntap.c

Loading...

sys/net/if_var.h

Loading...

sys/net/if_vlan.c

Loading...

sys/net/if_vxlan.c

Loading...

sys/net/iflib.c

Loading...

sys/net/iflib_clone.c

Loading...

sys/net/netisr.c

Loading...

sys/net/route.c

Loading...

sys/net/route/nhgrp_ctl.c

Loading...

sys/net/route/nhop_ctl.c

Loading...

sys/net/route/route_ctl.c

Loading...

sys/net/route/route_ddb.c

Loading...

sys/net/route/route_ifaddrs.c

Loading...

sys/net/route/route_rtentry.c

Loading...

sys/net/rtsock.c

Loading...