Page MenuHomeFreeBSD
Differential D37931

stand/efi/loader/copy.c: make sure kernel image is executable
ClosedPublic
Actions

Authored by fuz on Jan 2 2023, 9:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 5:32 PM
Unknown Object (File)
Fri, May 31, 4:17 PM
Unknown Object (File)
Wed, May 29, 7:30 PM
Unknown Object (File)
Wed, May 29, 7:30 PM
Unknown Object (File)
Wed, May 29, 7:30 PM
Unknown Object (File)
Tue, May 28, 4:18 AM
Unknown Object (File)
May 1 2024, 4:17 PM
Unknown Object (File)
Apr 22 2024, 8:35 PM
View All 40 Files
Subscribers
bcran
dab
imp

Details

Reviewers
allanjude
andrew
manu
tsoome
imp
kevans
Commits
rG9b0b515befac: loader.efi: make sure kernel image is executable
rG95fa2e0aee5b: loader.efi: make sure kernel image is executable
Summary

The Windows Dev Kit 2023 (Volterra) has an UEFI implementation that maps
EfiLoaderData pages as non-executable. Map the kernel as EfiLoaderCode
to ensure that it can be executed.

With this change, FreeBSD boots to the mountroot prompt if
hw.pac.enable = 0 is set in loader.conf(5).

Revisions D37765, D37766, and D37767 are needed for this one to work.

Sponsored by: Berliner Linux User Group e.V.
Sponsored by: spline / FU-Berlin

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fuz created this revision.Jan 2 2023, 9:27 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 2 2023, 9:27 PM
Herald added subscribers: dab, bcran, imp. · View Herald Transcript
fuz requested review of this revision.Jan 2 2023, 9:27 PM
Harbormaster completed remote builds in B48938: Diff 114717.Jan 2 2023, 9:27 PM
andrew added reviewers: tsoome, imp.Jan 2 2023, 9:34 PM

Id D37766 needed with this change?

fuz added a comment.Jan 2 2023, 9:41 PM

If I revert D37766, it still boots the same, so I guess it is not.

I have also not exhaustively checked if all four changes are needed. @andrew advised me to bulk-replace EfiLoaderData with EfiLoaderCode and that worked.

fuz added a reviewer: kevans.Jan 4 2023, 9:16 PM
imp accepted this revision.Jan 4 2023, 9:28 PM

These are the only ones I think we need, since none of the others are for executable code.... at least based on my quick grep...

stand/efi/loader/copy.c
333

This is good.

401

This is good.

418

This is good.

441

This is good.

This revision is now accepted and ready to land.Jan 4 2023, 9:28 PM
fuz added a comment.Jan 4 2023, 9:49 PM

@imp if you could do the honours and commit this, that would be great. I do not have any bits.

tsoome accepted this revision.Jan 4 2023, 10:18 PM
andrew accepted this revision.Jan 5 2023, 9:32 AM

I'll push later today

Closed by commit rG95fa2e0aee5b: loader.efi: make sure kernel image is executable (authored by fuz, committed by andrew). · Explain WhyJan 5 2023, 10:34 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG95fa2e0aee5b: loader.efi: make sure kernel image is executable.
andrew added a commit: rG9b0b515befac: loader.efi: make sure kernel image is executable.Jan 23 2023, 12:43 PM

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
8 lines

Diff 114767

View Options

stand/efi/loader/copy.c

Loading...