Differential D37767

Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit)
ClosedPublic
Actions

Authored by allanjude on Dec 20 2022, 9:38 PM.

Details

Reviewers

manu

Commits

rGfd5e9210598c: Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

allanjude created this revision.Dec 20 2022, 9:38 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 20 2022, 9:38 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 20 2022, 9:39 PM

Harbormaster failed remote builds in B48781: Diff 114342!

manu added inline comments.Dec 21 2022, 11:18 AM

sys/arm64/arm64/identcpu.c
202	That doesn't seems related.

fuz mentioned this in D37931: stand/efi/loader/copy.c: make sure kernel image is executable.Jan 2 2023, 9:27 PM

allanjude added inline comments.Jan 2 2023, 11:11 PM

sys/arm64/arm64/identcpu.c
202	yeah, that should move to its own commit

I think this is good with moving neoverse v2 to a separate commit.

This revision was not accepted when it landed; it landed in state Changes Planned.Jan 18 2023, 9:05 PM

This revision was landed with ongoing or failed builds.

Closed by commit rGfd5e9210598c: Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit) (authored by allanjude). · Explain Why

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rGfd5e9210598c: Add CPU Ident for Qualcomm Kryo 400 (used in MS Dev Kit).

I pulled the neoverse bits out, but didn't stage it properly, and the commit went in with the bits that were supposed to be excluded

Revision Contents
Changeset List

Path

Size

sys/

arm64/

identcpu.c

10 lines

include/

cpu.h

5 lines

Diff 115275

View Options

sys/arm64/arm64/identcpu.c