Page MenuHomeFreeBSD
Differential D37766

efi loader: allocate space for the kernel as code rather than data
AbandonedPublicDraft
Actions

Authored by allanjude on Dec 20 2022, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 1:16 AM
Unknown Object (File)
May 29 2024, 7:30 PM
Unknown Object (File)
May 1 2024, 12:20 PM
Unknown Object (File)
Apr 22 2024, 10:08 PM
Unknown Object (File)
Mar 20 2024, 11:42 AM
Unknown Object (File)
Feb 10 2024, 9:39 PM
Unknown Object (File)
Feb 3 2024, 8:17 AM
Unknown Object (File)
Jan 2 2024, 4:09 AM
View All 35 Files
Subscribers
bcran
dab
emaste
imp

Details

Reviewers
manu
Summary

This allows the boot loader to start on the Microsoft ARM dev kit 2023

Obtained from: OpenBSD (2c32ef33f5b1573564f64f1fbf0393c80a7eb0e8)
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

allanjude created this revision.Dec 20 2022, 9:38 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 20 2022, 9:38 PM
Herald added subscribers: dab, bcran, imp. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 20 2022, 9:39 PM
Harbormaster failed remote builds in B48780: Diff 114341!
imp added inline comments.Dec 25 2022, 4:07 AM
stand/efi/boot1/boot1.c
171

This is for the heap which isn't where we put the kernel...
I'm not sure how this would help.

stand/efi/loader/efi_main.c
100

Same. I think you'd need to change copy.c which is where we allocate pages for the kernel, metadata and loadable modules.

fuz mentioned this in D37931: stand/efi/loader/copy.c: make sure kernel image is executable.Jan 2 2023, 9:27 PM
imp added a comment.Jan 4 2023, 9:30 PM

Can you see if you can drop this change and still have things working? I'd be very keen to know either way.

emaste added a subscriber: emaste.Jan 24 2023, 8:43 PM
allanjude abandoned this revision.Mar 20 2023, 5:21 PM

This is not needed

Revision Contents
Changeset List

PathSize
stand/
efi/
boot1/
2 lines
loader/
2 lines

Diff 114341

View Options

stand/efi/boot1/boot1.c

Loading...
View Options

stand/efi/loader/efi_main.c

Loading...