Page MenuHomeFreeBSD

netinet*: remove dead code from TCP, UDP, SCTP control input
ClosedPublic

Authored by glebius on Sep 26 2022, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 5:44 AM
Unknown Object (File)
Fri, Oct 10, 4:40 PM
Unknown Object (File)
Fri, Oct 10, 4:39 PM
Unknown Object (File)
Fri, Oct 10, 4:39 PM
Unknown Object (File)
Fri, Oct 10, 11:05 AM
Unknown Object (File)
Tue, Sep 30, 11:11 AM
Unknown Object (File)
Mon, Sep 15, 12:06 AM
Unknown Object (File)
Aug 30 2025, 4:09 PM
Subscribers

Details

Summary

Now these functions are called only from icmp*_input(). The pointer to
the ICMP data is never NULL and cmd has a limited set of values.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/netinet/sctp_usrreq.c
277

Worth mentioning out why we can reference ip+ header fields

281

C99 init?

sys/netinet/tcp_subr.c
2898

Worth clarifying in the description that no one reacts on HOSTDEAD.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2022, 3:58 AM
This revision was automatically updated to reflect the committed changes.