Page MenuHomeFreeBSD

bus_if: provide a default null rescan method
ClosedPublic

Authored by mhorne on Jun 15 2022, 7:55 PM.
Tags
None
Referenced Files
F166288465: D35501.id107316.diff
Wed, Aug 12, 5:01 PM
F166218108: D35501.id106966.diff
Wed, Aug 12, 10:53 AM
Unknown Object (File)
Tue, Aug 11, 9:12 AM
Unknown Object (File)
Tue, Aug 11, 9:11 AM
Unknown Object (File)
Mon, Aug 10, 5:54 PM
Unknown Object (File)
Fri, Jul 24, 8:53 PM
Unknown Object (File)
Sun, Jul 19, 9:14 PM
Unknown Object (File)
Sat, Jul 18, 8:08 AM
Subscribers

Details

Summary

There is an existing helper method in subr_bus.c, but almost no drivers
know to use it. It also returns the same error as an empty method,
making it not very useful. Move this to bus_if.m and return a more
sensible error code.

This gives a slightly more meaningful error message when attempting
'devctl rescan' on buses and devices alike:

"Device not configured" --> "Operation not supported by device"

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Not sure about the ofw_pcibus.c changes, but the overall change is good, and the cardbus bits are also: There's no need to ever rescan cardbus since we always know (we have a polling backup in case the admin interrupts on that interface are wonky). Since we look so often, rescan will always be a nop.

This revision is now accepted and ready to land.Jun 15 2022, 7:59 PM
In D35501#805061, @imp wrote:

Not sure about the ofw_pcibus.c changes, but the overall change is good, and the cardbus bits are also: There's no need to ever rescan cardbus since we always know (we have a polling backup in case the admin interrupts on that interface are wonky). Since we look so often, rescan will always be a nop.

Thanks. I did at least look at the callers of BUS_RESCAN() and I did not see anything that depended on a particular error value being returned.

This revision was automatically updated to reflect the committed changes.