Differential D35382

crypto: Validate return values from CRYPTODEV_PROCESS()
ClosedPublic
Actions

Authored by markj on Jun 1 2022, 9:24 PM.

Tags

None

Referenced Files

	F168067802: D35382.id107665.diff
	Wed, Aug 26, 5:40 AM

	F167911474: D35382.diff
	Tue, Aug 25, 9:45 AM

	Unknown Object (File)
	Tue, Aug 25, 6:25 AM

	Unknown Object (File)
	Tue, Aug 25, 3:15 AM

	Unknown Object (File)
	Wed, Aug 19, 10:42 PM

	Unknown Object (File)
	Wed, Aug 19, 9:37 PM

	Unknown Object (File)
	Thu, Aug 13, 8:54 PM

	Unknown Object (File)
	Jul 21 2026, 3:04 AM

Subscribers

Details

Reviewers

jhb
kp
mav

Commits

rG99df914899f5: crypto: Validate return values from CRYPTODEV_PROCESS()

Summary

Errors are always handled by the completion callback, so we should check
that they're not also passed back to the caller.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 1 2022, 9:24 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptJun 1 2022, 9:24 PM

markj requested review of this revision.Jun 1 2022, 9:24 PM

Harbormaster completed remote builds in B45810: Diff 106546.Jun 1 2022, 9:24 PM

markj added a child revision: D35383: crypto: Remove the return value from crypto_dispatch(_async)().Jun 1 2022, 9:32 PM

kp accepted this revision.Jun 1 2022, 9:41 PM

This revision is now accepted and ready to land.Jun 1 2022, 9:41 PM

kp mentioned this in D35383: crypto: Remove the return value from crypto_dispatch(_async)().Jun 2 2022, 8:14 AM

jhb accepted this revision.Jun 29 2022, 9:45 PM

jhb added a reviewer: mav.

mav accepted this revision.Jun 30 2022, 3:03 AM

Closed by commit rG99df914899f5: crypto: Validate return values from CRYPTODEV_PROCESS() (authored by markj). · Explain WhyJul 1 2022, 3:31 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG99df914899f5: crypto: Validate return values from CRYPTODEV_PROCESS().

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

13 lines

Diff 107665

sys/opencrypto/crypto.c

Loading...