Page MenuHomeFreeBSD

exec: Simplify sv_copyout_strings implementations a bit
ClosedPublic

Authored by markj on Dec 30 2021, 10:41 PM.

Details

Summary

Simplify control flow around handling of the execpath length and signal
trampoline. Cache the sysentvec pointer in a local variable.

No functional change intended.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib added inline comments.
sys/kern/kern_exec.c
1634–1635

I suspect this code can be removed, but lets keep it for now. This variant is only for ABIs without shared page, and I think native FreeBSD ABI uses shared page on all arches.

1676–1677

szps can be eliminated. Initialize imgp->pagesizelen in place of szps, and substract it from destp

This revision is now accepted and ready to land.Dec 31 2021, 12:40 AM
sys/kern/kern_exec.c
1634–1635

That is these conditions could become KASSERTs in the future?

sys/kern/kern_exec.c
1634–1635

It would naturally traps on NULL access.

markj marked an inline comment as done.

Eliminate szps.

This revision now requires review to proceed.Dec 31 2021, 3:21 AM
This revision is now accepted and ready to land.Dec 31 2021, 4:03 PM