Page MenuHomeFreeBSD

Fix buffer overread in preloaded hostuuid parsing
ClosedPublic

Authored by jrtc27 on Dec 22 2021, 4:10 PM.
Tags
None
Referenced Files
F106406908: D33616.diff
Mon, Dec 30, 5:22 AM
Unknown Object (File)
Sat, Dec 21, 6:14 AM
Unknown Object (File)
Sat, Dec 21, 2:52 AM
Unknown Object (File)
Thu, Dec 5, 3:43 AM
Unknown Object (File)
Nov 14 2024, 2:32 PM
Unknown Object (File)
Nov 14 2024, 2:15 PM
Unknown Object (File)
Sep 21 2024, 3:21 AM
Unknown Object (File)
Sep 20 2024, 1:58 AM
Subscribers

Details

Summary

Commit b6be9566d236 stopped prison0_init writing outside of the
preloaded hostuuid's bounds. However, the preloaded data will not
(normally) have a NUL in it, and so validate_uuid will walk off the end
of the buffer in its call to sscanf. Previously if there was any
whitespace in the string we'd at least know there's a NUL one past the
end due to the off-by-one error, but now no such byte is guaranteed.

Fix this by copying to a temporary buffer and explicitly adding a NUL.

Whilst here, change the strlcpy call to use a far less suspicious
argument for dstsize; in practice it's fine, but it's an unusual pattern
and not necessary.

Found by: CHERI
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable