Page MenuHomeFreeBSD

Convert consumers to vm_page_alloc_noobj_contig()
AcceptedPublic

Authored by markj on Fri, Sep 17, 2:17 PM.

Details

Reviewers
alc
kib
hselasky
Summary

Remove now-unneeded page zeroing. No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41941
Build 38829: arc lint + arc unit

Event Timeline

markj requested review of this revision.Fri, Sep 17, 2:17 PM
hselasky added a subscriber: hselasky.

Looks good, assuming zero handling is preserved.

This revision is now accepted and ready to land.Fri, Sep 17, 2:30 PM
sys/amd64/amd64/mp_machdep.c
337

I observe that you eliminated VM_ALLOC_NOBUSY here but not elsewhere. Why?

sys/amd64/amd64/mp_machdep.c
337

No good reason. I think it makes sense to simply drop the VM_ALLOC_NOBUSY flag from all callers, as it is already implied by VM_ALLOC_NOOBJ.

sys/amd64/amd64/mp_machdep.c
337

I agree.

Drop unused VM_ALLOC_NOBUSY from consumers.

This revision now requires review to proceed.Fri, Sep 17, 7:08 PM

Drop uses of VM_ALLOC_NORMAL from vm_page_alloc_noobj_contig() and
vm_page_alloc_noobj_contig_domain() callers.

kib added inline comments.
sys/arm/nvidia/drm2/tegra_bo.c
105–106

The variable becomes somewhat pointless. You can directly pass _WIRED|_ALLOC_ZERO to vm_page_alloc_noobj_contig(), and vm_page_reclaim_contig() is fine with 0 instead pflags.

This revision is now accepted and ready to land.Mon, Oct 4, 1:47 AM
markj marked an inline comment as done.

Drop an unneeded local variable.

This revision now requires review to proceed.Mon, Oct 4, 1:59 AM
alc added inline comments.
sys/compat/linuxkpi/common/src/linux_page.c
107–108

Is PAGE_SIZE actually correct? I would guess that Linux guarantees that an order n allocation is aligned to an order n address. That said, at the moment, this is probably not an issue because of the way that vm_phys does contig allocations.

sys/powerpc/aim/mmu_radix.c
3582

Does VM_ALLOC_ZERO actually make sense here?

This revision is now accepted and ready to land.Sun, Oct 17, 1:04 AM