Page MenuHomeFreeBSD

x86: duplicate acpi_wakeup.c per i386 and amd64
ClosedPublic

Authored by kib on Mon, Sep 13, 5:02 PM.

Details

Summary

The file as is is the maze of #ifdef passages, all slightly different. Divorcing i386 and amd64 version actually makes changing the code easier, also no changes for i386 are planned.

amd64 wakeup: rework trampoline page allocation

There is no need to restrict trampoline page table to low 1M, it should work with any pages below 4G. Only wakeup code itself should be below 1M.

Do not waste level 5 page when LA48 mode is used.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Mon, Sep 13, 5:02 PM
kib created this revision.
sys/amd64/acpica/acpi_wakeup.c
333

Shouldn't it be i = 0?

kib marked an inline comment as done.

Fix silly off by one

This revision is now accepted and ready to land.Mon, Sep 13, 6:19 PM