Vendor import of NetBSD's testsuite at 2021-09-05
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 41387 Build 38276: arc lint + arc unit
Event Timeline
Comment Actions
I may be confused about tests and suits, but I think we have our own test suite for indent which NetBSD has taken and modified together with the program - and it seems to be coming back like a boomerang with this differential. I think theirs are not compatible unless we take in their changes. And it may be problematic, because I remember thinking that some of their changes would have to be improved before importing back to FreeBSD.
Comment Actions
Heya! I'll look at the commits to see what hasn't been pushed back and do what I can to pass it back to NetBSD.
Comment Actions
Thank you for doing that!
This change adds quite a lot of tests (which is really great).
I'm really positive on merging all these - that'd inrease test coverage for many utilities and kernel APIs.
What I'm a bit concerned is the number of added tests in a single commit. I suspect some of them will inevitably fail in some of the kernel configurations (and some may not be exactly relevant). It's also really hard to do a meaningful review, as I had to spend 5 minutes only to look through the list of tests to find the ones I'm interested at.
Would you mind splitting it into a set of smaller diffs, grouped by either topic (fs,net,kernel) or at least directory (bin, usr.bin, libc etc)? That would really help to conveniently view them in phabricator. Also, it'll help adding the relevant reviewers.