iflib: Add a new quirk
ClosedPublic
Actions

Authored by kd on Jun 11 2021, 3:06 PM.

Details

Reviewers

mw
wma
gallatin
shurd
erj

Group Reviewers

iflib

Commits

rG58632fa7a386: iflib: Add a new quirk

Summary

ENETC NIC found in LS1028A has a bug where clearing TX pidx/cidx causes the ring to hang after being re-enabled.
Add a new flag, if set iflib will preserve the indices during restart.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kd created this revision.Jun 11 2021, 3:06 PM

Herald added a reviewer: shurd. · View Herald TranscriptJun 11 2021, 3:06 PM

Herald added 1 blocking reviewer(s): iflib. · View Herald Transcript

Herald added subscribers: melifaro, ae. · View Herald Transcript

kd requested review of this revision.Jun 11 2021, 3:06 PM

kd added a child revision: D30729: Introduce new driver for NXP ENETC Ethernet controller.

gallatin requested changes to this revision.Jun 11 2021, 3:42 PM

gallatin added inline comments.

sys/net/iflib.h
408	You appear to have re-used the same flag as IFLIB_HAS_ADMINCQ. I assume this is not what you intended.

This revision now requires changes to proceed.Jun 11 2021, 3:42 PM

kd updated this revision to Diff 90863.Jun 14 2021, 7:27 AM

kd added inline comments.

sys/net/iflib.h
408	Whops, I should have checked that after rebasing. It is interesting though that git applied the patch cleanly here.

gallatin accepted this revision.Jun 14 2021, 7:14 PM

This revision is now accepted and ready to land.Jun 14 2021, 7:14 PM

erj accepted this revision.Jun 15 2021, 3:05 PM

Closed by commit rG58632fa7a386: iflib: Add a new quirk (authored by mw). · Explain WhyJun 24 2021, 11:12 AM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rG58632fa7a386: iflib: Add a new quirk.

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.h

4 lines

iflib.c

7 lines

Diff 90731

View Options

sys/net/iflib.h