Page MenuHomeFreeBSD

iflib: Add a new quirk
ClosedPublic

Authored by kd on Jun 11 2021, 3:06 PM.

Details

Summary

ENETC NIC found in LS1028A has a bug where clearing TX pidx/cidx causes the ring to hang after being re-enabled.
Add a new flag, if set iflib will preserve the indices during restart.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gallatin added inline comments.
sys/net/iflib.h
404–408

You appear to have re-used the same flag as IFLIB_HAS_ADMINCQ. I assume this is not what you intended.

This revision now requires changes to proceed.Jun 11 2021, 3:42 PM
kd added inline comments.
sys/net/iflib.h
404–408

Whops, I should have checked that after rebasing.
It is interesting though that git applied the patch cleanly here.

This revision is now accepted and ready to land.Jun 14 2021, 7:14 PM
This revision was automatically updated to reflect the committed changes.