Page MenuHomeFreeBSD

PRR: Avoid accounting left-edge twice in partial ACK.
ClosedPublic

Authored by rscheff on Feb 20 2021, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 7, 3:47 PM
Unknown Object (File)
Tue, Apr 7, 8:05 AM
Unknown Object (File)
Mon, Apr 6, 5:33 PM
Unknown Object (File)
Mon, Apr 6, 3:09 AM
Unknown Object (File)
Sun, Apr 5, 8:37 PM
Unknown Object (File)
Tue, Mar 31, 4:42 PM
Unknown Object (File)
Mon, Mar 30, 7:43 AM
Unknown Object (File)
Sat, Mar 28, 9:28 AM
Subscribers

Details

Summary

After D18624, accounting the advance of the left edge
in a partial ack is already included in
sackhint.delivered_data.

Therefore this is a cumulative error of the
prr_delivered bytes, over the course of multiple
partial acks while lost packets get acknowledged in
sequence.

Test Plan

Corrected behavior, maximum of 2 segments per ACK:

Incorrect behavior due to double-accounting (counterintutively, being more agressive pushing data out - 3 segments per ACK):

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff retitled this revision from PRR: avoid accounting left-edge twice in parital ack to PRR: Avoid accounting left-edge twice in partial ACK..Feb 20 2021, 7:42 PM
This revision is now accepted and ready to land.Feb 21 2021, 12:01 AM