Page MenuHomeFreeBSD

PRR: Avoid accounting left-edge twice in partial ACK.
AcceptedPublic

Authored by rscheff on Sat, Feb 20, 6:39 PM.

Details

Reviewers
kbowling
tuexen
jtl
rrs
thj
Group Reviewers
transport
Summary

After D18624, accounting the advance of the left edge
in a partial ack is already included in
sackhint.delivered_data.

Therefore this is a cumulative error of the
prr_delivered bytes, over the course of multiple
partial acks while lost packets get acknowledged in
sequence.

Test Plan

Corrected behavior, maximum of 2 segments per ACK:

Incorrect behavior due to double-accounting (counterintutively, being more agressive pushing data out - 3 segments per ACK):

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 37226
Build 34115: arc lint + arc unit

Event Timeline

rscheff retitled this revision from PRR: avoid accounting left-edge twice in parital ack to PRR: Avoid accounting left-edge twice in partial ACK..Sat, Feb 20, 7:42 PM
This revision is now accepted and ready to land.Sun, Feb 21, 12:01 AM