Page MenuHomeFreeBSD

PRR: Avoid accounting left-edge twice in partial ACK.
ClosedPublic

Authored by rscheff on Feb 20 2021, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 2:00 PM
Unknown Object (File)
Mon, Sep 22, 10:25 PM
Unknown Object (File)
Tue, Sep 16, 6:37 AM
Unknown Object (File)
Sep 10 2025, 1:55 PM
Unknown Object (File)
Sep 10 2025, 1:49 PM
Unknown Object (File)
Sep 10 2025, 1:42 PM
Unknown Object (File)
Sep 10 2025, 12:55 PM
Unknown Object (File)
Aug 27 2025, 12:36 AM
Subscribers

Details

Summary

After D18624, accounting the advance of the left edge
in a partial ack is already included in
sackhint.delivered_data.

Therefore this is a cumulative error of the
prr_delivered bytes, over the course of multiple
partial acks while lost packets get acknowledged in
sequence.

Test Plan

Corrected behavior, maximum of 2 segments per ACK:

Incorrect behavior due to double-accounting (counterintutively, being more agressive pushing data out - 3 segments per ACK):

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff retitled this revision from PRR: avoid accounting left-edge twice in parital ack to PRR: Avoid accounting left-edge twice in partial ACK..Feb 20 2021, 7:42 PM
This revision is now accepted and ready to land.Feb 21 2021, 12:01 AM