Differential D27991

hid: Import keyboard driver (hkbd)
ClosedPublic
Actions

Authored by wulf on Jan 6 2021, 12:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 17, 4:18 PM

	Unknown Object (File)
	Sun, May 17, 7:42 AM

	Unknown Object (File)
	Sat, May 16, 11:05 PM

	Unknown Object (File)
	Sat, May 16, 11:05 PM

	Unknown Object (File)
	Fri, May 15, 2:47 PM

	Unknown Object (File)
	Fri, May 15, 9:41 AM

	Unknown Object (File)
	Fri, May 15, 2:51 AM

	Unknown Object (File)
	Thu, May 14, 8:18 AM

Subscribers

None

Details

Reviewers

imp
avg
• hselasky
manu
val_packett.cool
markj

Commits

rGb93f6bfca343: hid: Port ukbd to HID and attach to build

Summary

This imports hkbd(4) driver which is conversion of existing ukbd(4) to the HID subsystem.

Unlike ukbd which is running entirely under Giant, hkbd uses 2 locks - private mutex for interrupt handler/repeat callout and Giant for syscons interface. Lockless queue is used for passing of key-press events from mtx-protected code to Giant-protected one. Other differences are minor.

This revision is subset of https://reviews.freebsd.org/D27777

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jan 6 2021, 12:54 AM

wulf created this revision.

wulf edited the summary of this revision. (Show Details)Jan 6 2021, 1:15 AM

Looks good.

This revision is now accepted and ready to land.Jan 7 2021, 12:57 PM

Closed by commit rGb93f6bfca343: hid: Port ukbd to HID and attach to build (authored by wulf). · Explain WhyJan 7 2021, 11:23 PM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rGb93f6bfca343: hid: Port ukbd to HID and attach to build.

wulf mentioned this in rG2775d1d5d1ef: hkbd(4): Split driver lock on interrupt and syscons locks.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

1 line

59 lines

sys/

conf/

3 lines

1 line

dev/

hid/

1354 lines

modules/

hid/

1 line

hkbd/

10 lines

Diff 81851

share/man/man4/Makefile

Loading...

share/man/man4/hkbd.4

Loading...

sys/conf/files

Loading...

sys/conf/options

Loading...

sys/dev/hid/hkbd.c

Loading...

sys/modules/hid/Makefile

Loading...

sys/modules/hid/hkbd/Makefile

Loading...